Fix pr reviews

getdokan · Nov 1, 2024 · 74793f1 · 74793f1
1 parent 79424a0
commit 74793f1
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/.github/workflows/e2e_api_tests.yml b/.github/workflows/e2e_api_tests.yml
@@ -46,8 +46,6 @@ env:
     CUSTOMER2: customer2
     USER_PASSWORD: 01dokan01
     GMAP: ${{secrets.GMAP}}
-    TALKJS_APP_ID: ${{secrets.TALKJS_APP_ID}}
-    TALKJS_APP_SECRET: ${{secrets.TALKJS_APP_SECRET}}
     BASE_URL: http://localhost:9999
     CI: true
     FORCE_COLOR: 1

diff --git a/tests/pw/pages/liveChatPage.ts b/tests/pw/pages/liveChatPage.ts
@@ -36,7 +36,7 @@ export class LiveChatPage extends BasePage {
         await this.toBeVisibleFrameLocator(liveChatVendor.liveChatIframe, liveChatVendor.sendButton);
     }
 
-    // vendor send message to vendor customer
+    // vendor send message to customer
     async sendMessageToCustomer(chatPerson: string, message: string): Promise<void> {
         await this.goIfNotThere(data.subUrls.frontend.vDashboard.inbox);
         await this.clickFrameSelector(liveChatVendor.liveChatIframe, liveChatVendor.chatPerson(chatPerson));
@@ -47,7 +47,7 @@ export class LiveChatPage extends BasePage {
 
     // customer
 
-    // customer send message to vendor customer
+    // customer send message to vendor
     async sendMessageToVendor(storename: string, message: string): Promise<void> {
         await this.gotoSingleStore(storename, true);
         await this.click(singleStoreCustomer.storeTabs.chatNow);
@@ -57,7 +57,8 @@ export class LiveChatPage extends BasePage {
         await this.toBeVisibleFrameLocator(liveChatCustomer.liveChatIframe, liveChatCustomer.sentMessage(message));
     }
 
-    async viewLiveChatButtonOnStore(storename: string, disable = false) {
+    // view chat button on vendor page
+    async viewLiveChatButtonOnStore(storename: string, disable = false): Promise<void> {
         await this.gotoSingleStore(storename, true);
         if (!disable) {
             await this.toBeVisible(singleStoreCustomer.storeTabs.chatNow);
@@ -66,7 +67,8 @@ export class LiveChatPage extends BasePage {
         }
     }
 
-    async viewLiveChatButtonOnProduct(productName: string, option: string) {
+    // view chat button on product page
+    async viewLiveChatButtonOnProduct(productName: string, option: 'above-tab' | 'inside-tab' | 'dont-show'): Promise<void> {
         await this.goToProductDetails(productName, true);
 
         switch (option) {

diff --git a/tests/pw/pages/productsPage.ts b/tests/pw/pages/productsPage.ts
@@ -680,7 +680,7 @@ export class ProductsPage extends AdminPage {
         await this.hover(productsVendor.productCell(productName));
         await this.clickAndWaitForLoadState(productsVendor.view(productName));
         await expect(this.page).toHaveURL(data.subUrls.frontend.productDetails(helpers.slugify(productName)) + '/');
-        const { quantity, addToCart, viewCart, euComplianceData, productAddedSuccessMessage, productWithQuantityAddedSuccessMessage, ...productDetails } = selector.customer.cSingleProduct.productDetails;
+        const { quantity, addToCart, viewCart, chatNow, euComplianceData, productAddedSuccessMessage, productWithQuantityAddedSuccessMessage, ...productDetails } = selector.customer.cSingleProduct.productDetails;
         await this.multipleElementVisible(productDetails);
     }
 

diff --git a/tests/pw/pages/selectors.ts b/tests/pw/pages/selectors.ts
@@ -2418,7 +2418,6 @@ export const selector = {
                 // Live Chat
                 liveChat: {
                     enableLiveChat: '//label[@for="dokan_live_chat[enable]"]',
-
                     chatProvider: (provider: string) => `//label[contains(@for,'${provider}-provider')]`,
 
                     // Fb

diff --git a/tests/pw/tests/e2e/liveChat.spec.ts b/tests/pw/tests/e2e/liveChat.spec.ts
@@ -25,6 +25,7 @@ test.describe('Live chat test', () => {
 
     test.afterAll(async () => {
         await dbUtils.setOptionValue(dbData.dokan.optionName.liveChat, dbData.dokan.liveChatSettings);
+        await vPage.close();
         await cPage.close();
     });