fix: Store category count sync for multiple language

[shohag121]

Implemented Store category saving and fetching filters.

This will help syncing and preserving Category count.

• fix: ⚠️⚠️⚠️ WPML / DOKAN - ISSUE STORE CATEGORY - not synchronise at all (in default languages and in translated categories) #53
• Related PR https://github.com/getdokan/dokan-pro/pull/3269

        add_filter( 'dokan_set_store_categories', [ $this, 'set_translated_category' ] );
        add_filter( 'dokan_get_store_categories_in_vendor', [ $this, 'get_translated_category' ] );


    /**
     * Set store categories with default language to store.
     *
     * @since 1.1.3
     *
     * @param array $categories Store Categories.
     *
     * @return array
     */
    public function set_translated_category( $categories ) {
        if ( ! function_exists( 'wpml_object_id_filter' ) || ! function_exists( 'wpml_get_default_language' ) ) {
            return $categories;
        }

        $all_categories = [];

        foreach ( $categories as $store_cat_id ) {
            $translated_cat_id = wpml_object_id_filter( $store_cat_id, 'store_category', true, wpml_get_default_language() );

            if ( ! in_array( $translated_cat_id, $all_categories ) ) {
                $all_categories[] = $translated_cat_id;
            }
        }

        return $all_categories;
    }

    /**
     * Get store categories with current translation to store.
     *
     * @since 1.1.3
     *
     * @param WP_Term[] $categories Store Categories.
     *
     * @return array
     */
    public function get_translated_category( $categories ) {
        if ( ! function_exists( 'wpml_object_id_filter' ) ) {
            return $categories;
        }

        $category_ids = array_unique(
            array_map(
                function ( $store_cat ) {
                    return wpml_object_id_filter( $store_cat->term_id, 'store_category', true, null );
                    },
                $categories
            )
        );

        return array_map(
            function ( $category_id ) {
                return get_term( $category_id, 'store_category' );
            },
            $category_ids
        );
    }

Summary by CodeRabbit

• New Features

  • Enhanced multilingual support by introducing translated store categories.

• Improvements

  • Improved configuration for multilingual taxonomy handling.

[Sophie-2e]

Hello @shohag121 and @Aunshon hope you enjoyed your holidays. When can we expect the fix to be released as still not working with Dokan 3.10.2?

[Sophie-2e]

Hello @aihimel @shohag121 @StalinDurjo @Aunshon

Just tested your solution by adding the line of codes missing in Dokan WPML but it does not work. Is the store categories registered in the user profile metadata?

Because if yes, only a few user profile metadata are translatable by default with WPML, here for your reference: https://wpml.org/documentation/getting-started-guide/string-translation/translating-user-meta-information-with-wpml/

So if store categories are indeed registered as user profile metadata, you need to add extra code to make them translatable and ensure that when a user registers the store category in one language, it gets automatically registered for the other language. Here is a tutorial that will help you understand the logic behind and so achieve the results wanted if store categories are indeed user profile metadata: https://gist.github.com/senlin/4fd15ba7a19533ceb9fe

If you need a video with more explanations and proof that this current fix is not working, ask Yeasin about the last video I sent in support ticket #60772

Hope that helps, let me know, waiting for your news

[coderabbitai]

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

Commits

Files that changed from the base of the PR and between 025ac27 and ef3882c.

Files selected for processing (1)

• dokan-wpml.php (4 hunks)

 _____________________________________________________________________________
< I took both the red pill and the blue pill. Now I'm stuck in a code review. >
 -----------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

Walkthrough

The changes enhance multilingual support in the Dokan plugin by introducing functions to handle translated store categories and updating the WPML configuration to synchronize these categories across different languages.

Changes

Files	Change Summary
dokan-wpml.php	Added set_translated_category and get_translated_category functions to manage translated store categories.
wpml-config.xml	Added a new <taxonomies> section with a <taxonomy> element for store_category to support translations.

Assessment against linked issues

Objective (Issue #)	Addressed	Explanation
Synchronize store categories in default and translated languages (#53)	✅
Add settings to handle the translation of store categories in WPML (#53)	✅

In the garden of code where features bloom,
A rabbit hops, dispelling gloom.
With functions new and taxonomies bright,
Multilingual stores take flight.
Categories sync, translations align,
In this digital world, everything's fine. 🐇🌐

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 073c784 and 025ac27.

Files selected for processing (2)

• dokan-wpml.php (4 hunks)
• wpml-config.xml (1 hunks)

Files skipped from review due to trivial changes (1)

• wpml-config.xml

Additional comments not posted (3)

dokan-wpml.php (3)

651-667: The implementation of set_translated_category aligns with the PR objectives to sync store categories across languages. Consider adding error handling or logging when WPML functions are not available.

---

678-698: The implementation of get_translated_category correctly fetches translated categories. Consider adding a comment to clarify why null is used as the language parameter in wpml_object_id_filter, which defaults to the current language.

---

160-161: Integration of set_translated_category and get_translated_category with Dokan hooks is correctly implemented.

[Sophie-2e]

@Aunshon @shohag121 @shashwatahalder01 it is still not synchronise properly with Dokan WPML 1.1.3. Please review comment here and reopen the GitHub: #53 (comment)