Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept the shell argument for fish #108

Merged
merged 1 commit into from
May 9, 2016

Conversation

rgbkrk
Copy link
Contributor

@rgbkrk rgbkrk commented May 5, 2016

Rely on --shell in the same way Windows users deal with.

I made this use $SHELL at first then realized an inconsistency with the other
tooling. Would it be ok to make --shell the primary choice with a fallback
to whatever $SHELL is defined as to determine the script?

kyle@lack ~/c/s/g/g/carina> make; and ./carina env test2 --shell fish
go get ./...
CGO_ENABLED=0 go build -a -tags netgo -ldflags '-w -X github.com/getcarina/carina/version.Commit=f0818b51ab726075b500a11fd079a9c20eb5a1de -X github.com/getcarina/carina/version.Version=v1.3.0-8-gf0818b5' -o carina .
source /Users/rgbkrk/.carina/clusters/rgbkrk/test2/docker.fish
# Run the command below to get your Docker environment variables set:
# eval $(carina env test2)

Rely on --shell in the same way Windows users deal with.

I made this use $SHELL at first then realized an inconsistency with the other
tooling. Would it be ok to make `--shell` the primary choice with a fallback
to whatever $SHELL is defined as to determine the script?
@rgbkrk
Copy link
Contributor Author

rgbkrk commented May 6, 2016

/cc @carolynvs

@carolynvs carolynvs merged commit f63790d into getcarina:master May 9, 2016
@rgbkrk rgbkrk deleted the here-fishie-fishie branch May 9, 2016 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants