Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creator does not ensure the subset has only alphabetical characters #289

Closed
BigRoy opened this issue Oct 18, 2017 · 3 comments · Fixed by #448
Closed

Creator does not ensure the subset has only alphabetical characters #289

BigRoy opened this issue Oct 18, 2017 · 3 comments · Fixed by #448

Comments

@BigRoy
Copy link
Collaborator

BigRoy commented Oct 18, 2017

Currently the instance creator does not ensure the subset has a name consisting only of alphabetical characters, any symbol, space or special characters seems to be allowed in the Creator.

Is this ok to be generic and abstract? Or should it never allow so to begin with?

For example, should a space even be allowed? Or more specific, what characters should be?

@mottosso
Copy link
Contributor

It should be the case that bad names cannot make it into the database, due to this

Currently the allowed characters are ^[a-zA-Z0-9_.]*$. We should get that filter into the UI as well.

@BigRoy
Copy link
Collaborator Author

BigRoy commented Oct 19, 2017

It should be the case that bad names cannot make it into the database, due to this.

Perfect. Thanks for pointing that out, good to know. That should definitely find its way into the UI too.

@davidlatwe davidlatwe self-assigned this Sep 11, 2019
@davidlatwe
Copy link
Collaborator

On UX part, this could be related to #179, and with the implementation in #444, use reddish border-color to indicate invalid subset name.

Will submit another PR to resolve this, after #444 is merged.

davidlatwe referenced this issue Sep 17, 2019
Fix#289: Validate subset name for database
tokejepsen pushed a commit to tokejepsen/core that referenced this issue May 6, 2021
…ally-add-task-to-subset-name

Optionally add task to subset name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants