Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Commit

Permalink
Merge #971
Browse files Browse the repository at this point in the history
971: Fix volume path r=bonomat a=lukechilds

Using the relative path like this instead of an abolute path when trying to start a container I just get the error:

```
ERROR: for itchysats_web_1  Cannot start service web: OCI runtime create failed: invalid mount {Destination:data Type:bind Source:/var/lib/docker/volumes/3373facda23457bc501bfff215d91789cc1ee4f20c043d4b929bed56fc691305/_data Options:[rbind]}: mount destination data not absolute: unknown

ERROR: for web  Cannot start service web: OCI runtime create failed: invalid mount {Destination:data Type:bind Source:/var/lib/docker/volumes/3373facda23457bc501bfff215d91789cc1ee4f20c043d4b929bed56fc691305/_data Options:[rbind]}: mount destination data not absolute: unknown
ERROR: Encountered errors while bringing up the project.
```

It seems like only certain versions of Docker fail without this, I can get your current Docker image to run on some machines but not others without this change. However with this change it runs correctly on all of my machines.

Related: getumbrel/umbrel#1149 (review)

Co-authored-by: Luke Childs <[email protected]>
  • Loading branch information
bors[bot] and lukechilds authored Dec 27, 2021
2 parents 61c7bcb + 712918c commit 23c0341
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ ARG BINARY_PATH

COPY $TARGETPLATFORM/$BINARY_PATH /usr/bin/binary

VOLUME data
VOLUME /data

# HTTP Port and P2P Port
EXPOSE 8000 9999
Expand Down

0 comments on commit 23c0341

Please sign in to comment.