Remove insane compile_error!
#2611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was trying to fail at compile time based on a runtime value (the settings). This is dumb. We now fail at runtime if we try to use a fixed index price in release mode. Production always runs on release, so this exists to prevent using a fixed index price in production. Obviously, release does not always equal production, but using the real index price from BitMEX is fine in most scenarios (except for the e2e tests and some instances of local testing).
holzeis
approved these changes
Jun 5, 2024
bonomat
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to fail at compile time based on a runtime value (the settings). This is dumb.
We now fail at runtime if we try to use a fixed index price in release mode. Production always runs on release, so this exists to prevent using a fixed index price in production.
Obviously, release does not always equal production, but using the real index price from BitMEX is fine in most scenarios (except for the e2e tests and some instances of local testing).
This should fix problems like this one, which were preventing us from building the coordinator in release mode 🤦