feat: store some metrics in db #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These weren't used but exposed so we better remove them.
luckysori
approved these changes
May 29, 2024
coordinator/src/bin/coordinator.rs
Outdated
| scheduler | ||
| .add_collect_metrics_job(pool.clone()) | ||
| .await | ||
| .expect("To add the close liquidated position reminder job"); |
There was a problem hiding this comment.
Suggested change
| .expect("To add the close liquidated position reminder job"); | |
| .expect("To add the collect metrics job"); |
Creats a new table called `metrics` which is meant to be used to store business metrics which are not collected otherwise, such as, - on-chain balance - ln-balance
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought this could come handy.
For start, we are storing on-chain balance in the DB every hour.