fix: Don't refresh TradingView when switching from wallet to trading tab #2538
Conversation
|
I think the approach makes sense. |
It keeps the state for all of the pages under the wallet & trade screen. This may or may not be an issue but I'm not quite sure how to evaluate it. |
I guess this is ok given our application is quite small. |
|
Going to update the animation now and then make this ready for merge |
|
Actually, this branch might be fine. Here is how it looks on main: And on this branch We could try implement a slide animation or leave it as is |
holzeis
changed the title
The webview plugin we are using is not supported on desktop. Try running it in a simulator. |
I'm not testing the webview plugin but rather the animation of switching between the two views themselves. Specifically, on the main branch the one view kind of 'pops up' and replaces the other one, as if they are being stacked on top of eachother. In this branch, it instantly replaces the one view with the other with no animation. It works fine with the webview plugin on the real device as well, but it's just harder for me to make a screen recording on that because I can't get 10101 to compile for the simulator at the moment |
|
I'm going to merge this for now and we can change the animation in a followup if we like |
Fixes #2525
I can say for certain that going into settings still triggers a refresh - I'm not sure if we care about this, though. Otherwise, it seems to work and it does not refresh when swapping from wallet to trading tab. If this general approach is acceptable (which maybe has wider-reaching impacts?), then I can re-add the animation to swap from wallet to trade tabs and we can merge this.