Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two resize bugs #2412

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Fix two resize bugs #2412

merged 2 commits into from
Apr 11, 2024

Conversation

luckysori
Copy link
Contributor

Fixes #2404.

luckysori and others added 2 commits April 11, 2024 20:42
The new margin has to be based on the original price.

Similarly, the margin reduction also hast to be based on the original
price.

Co-authored-by: Philipp Hoenisch <[email protected]>
@luckysori luckysori self-assigned this Apr 11, 2024
Copy link
Contributor

@holzeis holzeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@holzeis holzeis added this pull request to the merge queue Apr 11, 2024
Merged via the queue into main with commit a82e93a Apr 11, 2024
23 checks passed
@holzeis holzeis deleted the fix/resize-bugs branch April 11, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return from position resize seems wrong
2 participants