Calculate coordinator position PNL correctly #2325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luckysori
force-pushed
the
fix/coordinator-pnl
branch
from
da08966
to
c811803
Compare
We were using the closing trade trader direction instead of the position direction.
luckysori
force-pushed
the
fix/coordinator-pnl
branch
from
c811803
to
928c1e9
Compare
luckysori
changed the title
bonomat
approved these changes
Mar 26, 2024
@bonomat that might have been the reason why our leaderboard was not correct. |
Maybe, although, it was correct for some time until someone introduced the bug again ~2 weeks ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using the closing trade trader direction instead of the position direction.