Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: switch to hashrouter for go filesystem routing #56

Merged
merged 2 commits into from
Nov 21, 2024
Merged

chore: switch to hashrouter for go filesystem routing #56

merged 2 commits into from
Nov 21, 2024

Conversation

markphelps
Copy link
Contributor

@markphelps markphelps commented Nov 21, 2024 •
edited
Loading

  • switch to hash router so that when embedded the go app can handle hard refreshes
  • add synced status to phase and show when up to date in UI
  • switch to shadcn tooltip for better darkmode support

CleanShot 2024-11-21 at 11 37 07@2x
CleanShot 2024-11-21 at 11 37 01@2x

@markphelps markphelps requested a review from GeorgeMac November 21, 2024 16:14
@markphelps
feat: add up to date icon
9fb40e1 
Signed-off-by: Mark Phelps <[email protected]>
GeorgeMac
GeorgeMac approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👌

@kodiakhq kodiakhq bot merged commit a0d958a into main Nov 21, 2024
2 checks passed
@kodiakhq kodiakhq bot deleted the hash-router branch November 21, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgeMac GeorgeMac GeorgeMac approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markphelps @GeorgeMac