-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add server configuration #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Have some feedback. This is currently breaking defaults / validation for Credentials and Sources (we must be nearing test time 😂).
For example, when running this code with our internal pipeline. I see the following error when I use basic auth without a password:
➜ go run ./cmd/glu/. inspect
panic: building pipeline: git "foundation": performing initial fetch: invalid auth method
With either of the suggestions below this becomes:
➜ go run ./cmd/glu/. inspect
panic: configuring pipeline: both username and password need to be provided for basic auth
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
3918097
to
3120e9d
Compare
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
@GeorgeMac I think I addressed all feedback and even added some basic unit tests for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sick
Co-authored-by: George <[email protected]>
Fixes: FLI-1338
setDefaults
andvalidate
run automatically for types that implement them in the config struct