Add missing supports-color
dependency
#349
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Our
package-lock.json
file is a mess for a variety of reasons I won't bore you with but while removing an ancient version ofwebpack-dev-server
that usedsupports-color
from our application it ended up deletingnode_modules/supports-color
; however because Alex has an implicit dependency on this by way ofvfile-reporter
it leftnode_modules/vfile-reporter/node_modules/supports-color
alone.Unfortunately because this is an implicit and not an explicit dependency Alex began to throw the following error for us:
Installing
supports-color
as a development dependency of our application placessupports-color
back into the rootnode_modules
directory and makes Alex work again.Because Alex directly depends on this module it should list it as an explicit dependency.