ENH: Add 2024-02-09 Chinese New Year to XSHG #365
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XSHG is missing last Friday from its list, which was the beginning of the Chinese New Year celebrations - see http://english.sse.com.cn/start/trading/schedule/ for the canonical list of holidays for 2024. I've also checked no others are missing. 👍🏻
Workflow to modify an existing Exchange Calendar
tests/resources/{Exchange MIC}.csv
), either manually or by executingpython etc/make_exchange_calendar_test_csv.py {Exchange MIC}
.tests/test_{Exchange MIC}_calendar.py
need updating to reflect your changes.exchange_calendars/exchange_calendar_{Exchange MIC}.py
.