Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xkls_holidays.py and xkls.csv #30

Merged
merged 2 commits into from
Jun 20, 2021
Merged

Update xkls_holidays.py and xkls.csv #30

merged 2 commits into from
Jun 20, 2021

Conversation

mrkgoh
Copy link

@mrkgoh mrkgoh commented Jun 8, 2021

for Thaipusam, Deepavali and Yang Di-pertuan Agong's Birthday

mrkgoh added 2 commits June 8, 2021 13:06
for Thaipusam, Deepavali and Yang Di-pertuan Agong's Birthday
remove 2020-06-08
@mrkgoh mrkgoh changed the title Update Holidays Update xkls_holidays.py and xkls.csv Jun 8, 2021
@mrkgoh mrkgoh marked this pull request as ready for review June 8, 2021 06:08
@mrkgoh
Copy link
Author

mrkgoh commented Jun 8, 2021

@gerrymanoim finally I think I got it right.

@mrkgoh
Copy link
Author

mrkgoh commented Jun 11, 2021

@gerrymanoim , checks have passed.

@gerrymanoim
Copy link
Owner

Thanks!

@gerrymanoim gerrymanoim merged commit 27d50fa into gerrymanoim:master Jun 20, 2021
@mrkgoh
Copy link
Author

mrkgoh commented Jun 21, 2021

@gerrymanoim when will I be able pip install --upgrade with this commit?

@gerrymanoim
Copy link
Owner

Whenever we next cut a release. Should be soonish - but I'd like to get a few other PRs in this release.

@mrkgoh
Copy link
Author

mrkgoh commented Jun 21, 2021

@gerrymanoim ok. I am using this library in my stock bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants