Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added public holidays before 1999 in XSHG. #147

Merged

Conversation

qiuwei
Copy link

@qiuwei qiuwei commented Feb 15, 2022

Workflow to add a new Exchange Calendar

It's recommended that whilst working through the process reference be made to existing calendar and test classes.

Workflow to modify an existing Exchange Calendar

  • Modify calendar class as required.
  • Modify the test resources file (e.g tests/resources/{Exchange MIC}.csv), either manually or by executing python etc/make_exchange_calendar_test_csv.py {Exchange MIC}.
  • Check if any of the fixtrues in tests/test_{Exchange MIC}_calendar.py need updating to reflect your changes.
  • Add references to any new/modified holidays in exchange_calendars/exchange_calendar_{Exchange MIC}.py.

@gerrymanoim
Copy link
Owner

This is great - Thanks! You can ignore the CI error, that will be fixed via #146.

@gerrymanoim gerrymanoim merged commit e5b2874 into gerrymanoim:master Feb 16, 2022
@codeterm codeterm mentioned this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants