Fix assert_has/refute_has title matching exactly #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What changed? ============ Our `assert_has/3` and `refute_has/3` helpers with `"title"` behave differently from the rest of our assertion helpers. By default our other assertion helpers perform a match (`=~`) operation. Our "title" assertion performs an equality (`==`) operation. In addition to being different from the rest, it's annoying because we typically render the title with a `<.live_title>` tag which has newlines and spaces. We fix that in this commit and allow people to pass `exact: true` to match exactly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #64
What changed?
Our
assert_has/3andrefute_has/3helpers with"title"behave differently from the rest of our assertion helpers.By default our other assertion helpers perform a match (
=~) operation. Our "title" assertion performs an equality (==) operation.In addition to being different from the rest, it's annoying because we typically render the title with a
<.live_title>tag which has newlines and spaces.We fix that in this commit and allow people to pass
exact: trueto match exactly.