Handle form redirects in Live pages #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What changed? ============ Our `Live` implementation doesn't handle form redirects, be they to another LiveView with `push_navigate/2` or to a static page via `redirect/2`. This commit updates the implementation to follow redirects the same way we follow redirects when we click on links. Testing note ----------- We also create a new describe block to for testing `fill_form/3` + `click_button/2`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19
What changed?
Our
Liveimplementation doesn't handle form redirects, be they to another LiveView withpush_navigate/2or to a static page viaredirect/2.This commit updates the implementation to follow redirects the same way we follow redirects when we click on links.
Testing note
We also create a new describe block to encapsulate all the testing for
fill_form/3+click_button/2.