Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request Accept property handler #47

Open
gknoll9862 opened this issue Apr 3, 2021 · 12 comments
Open

Feature request Accept property handler #47

gknoll9862 opened this issue Apr 3, 2021 · 12 comments

Comments

@gknoll9862
Copy link

Could you please add a handler to apply the Accept values to the HttpWebRequest.Accept property?

Thank you

Greg

@geral2
Copy link
Owner

geral2 commented Apr 5, 2021

Hello @gknoll9862,

What property are you trying to apply?
Just to confirm if that can be done through the Header cofllection.

@gknoll9862
Copy link
Author

gknoll9862 commented Apr 5, 2021 via email

@geral2
Copy link
Owner

geral2 commented Apr 5, 2021

Did you try calling that API from Postman?... If so could you please show the headers and parametters passed?

@gknoll9862
Copy link
Author

gknoll9862 commented Apr 5, 2021 via email

@gknoll9862
Copy link
Author

gknoll9862 commented Apr 5, 2021 via email

@geral2
Copy link
Owner

geral2 commented Apr 5, 2021

Got it, I'll be uploading a new version which assign that Accept value from headers to the httprequest.
In addition to a table value function object which returns the result set without needing that table variable be declared.

@gknoll9862
Copy link
Author

gknoll9862 commented Apr 5, 2021 via email

@joelmiles
Copy link

Got it, I'll be uploading a new version which assign that Accept value from headers to the httprequest.
In addition to a table value function object which returns the result set without needing that table variable be declared.

Curious when this new version will be uploaded. I'm hitting the same problem.

Thanks for such a great tool!

@geral2
Copy link
Owner

geral2 commented Aug 31, 2021

Hello there,

Sorry for the delay, This fix was already coded, I just need to test it and upload it. I haven't had much time these days.

But you could help testing it. I can upload a new branch. I added all the request properties below;

  • "Host"
  • "Referer"
  • "MediaType"
  • "TransferEncoding"
  • "Accept"
  • "Connection"
  • "ConnectionGroupName"
  • "Expect"
  • "ContentLength"
  • "Pipelined"
  • "AllowAutoRedirect"
  • "KeepAlive"
  • "ReadWriteTimeout"

@gknoll9862
Copy link
Author

gknoll9862 commented Aug 31, 2021 via email

@gknoll9862
Copy link
Author

Greetings Mr. Diaz,

In your last post you mentioned you where going to start a new branch and upload the new code to be tested.
I am not seeing the new branch.

I would very much like to start testing some of this for you.

Thank you
Greg

@geral2
Copy link
Owner

geral2 commented Feb 28, 2022

Hello @gknoll9862,

I forgot to mention but I uploaded a version with this change. Could you please take a look on brank release_v2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants