Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't recognize multi-line lib_deps entry #144

Closed
fiveangle opened this issue Aug 18, 2017 · 8 comments
Closed

Doesn't recognize multi-line lib_deps entry #144

fiveangle opened this issue Aug 18, 2017 · 8 comments

Comments

@fiveangle
Copy link

Mac OS Siera, Windows 7

Doesn't recognize multi-line lib_deps entry in common section of platformio.ini

  • Open project with multi-line lib_deps like this one
  • Attempt to select Environment and observe unable to do so
  • Edit multi-line lib_deps entry to be single-line comma-separated:
    multi-line_lib_deps
  • Observe able to select Environment now
gepd added a commit that referenced this issue Aug 21, 2017
…arser has not problem opening files with multiline options. (Issue: #144)
@gepd
Copy link
Owner

gepd commented Aug 21, 2017

I've changed the library used to open .ini files, now, it seems to work fine with multi-line options, please test it and let me know if it's working for you too

@fiveangle
Copy link
Author

Did a package upgrade/overwrite and with original multiline source, it picked up the libraries no problem.

Thanks !

-=dave

[ Deviot 2.1.1 ] Starting...
[Fri Aug 25 20:19:06 2017] Processing Re-ARM (extra_scripts: Marlin/src/HAL/HAL_LPC1768/lpc1768_flag_script.py; build_flags: !python Marlin/src/HAL/HAL_LPC1768/lpc1768_flag_script.py; lib_deps: U8glib-ARM; board_f_cpu: 100000000L; platform: nxplpc; lib_ldf_mode: off; src_filter: +<*> -<example_configurations> -<src/HAL/HAL_*> -<frameworks> +<src/HAL/HAL_LPC1768> +<frameworks/CMSIS/LPC1768> -</Users/speedster/dev/github/Marlin/Marlin/Marlin.ino> +</Users/speedster/dev/github/Marlin/Marlin/Marlin.cpp>)
--------------------------------------------------------------------------------
Library Storage: /Users/speedster/dev/github/Marlin/.piolibdeps
LibraryManager: Installing id=1691
U8glib-ARM @ 1.18.1 is already installed
Collected 8 compatible libraries
Looking for dependencies...
Library Dependency Graph
|-- <U8glib-ARM> v1.18.1 (/Users/speedster/dev/github/Marlin/.piolibdeps/U8glib-ARM_ID1691)
arm-none-eabi-g++ -o .pioenvs/Re-ARM/src/G26_Mesh_Validation_Tool.o -c -fno-rtti -fno-exceptions -std=gnu++11 -fabi-version=0 -fno-use-cxa-atexit -fno-threadsafe-statics -g -Os -ffunction-sections -fdata-sections -Wall -mthumb -nostdlib -Os -mcpu=cortex-m3 -mthumb -ffreestanding -fsigned-char -fno-move-loop-invariants -Wall --specs=nano.specs --specs=nosys.specs -MMD -MP -DF_CPU=100000000L -DPLATFORMIO=30500 -DTARGET_LPC1768 -DIS_REARM -IMarlin/frameworks/CMSIS/LPC1768/include -IMarlin/frameworks/CMSIS/LPC1768/lib -IMarlin/src/HAL -IMarlin -I.piolibdeps/U8glib-ARM_ID1691/src Marlin/G26_Mesh_Validation_Tool.cpp
arm-none-eabi-g++ -o .pioenvs/Re-ARM/src/I2CPositionEncoder.o -c -fno-rtti -fno-exceptions -std=gnu++11 -fabi-version=0 -fno-use-cxa-atexit -fno-threadsafe-statics -g -Os -ffunction-sections -fdata-sections -Wall -mthumb -nostdlib -Os -mcpu=cortex-m3 -mthumb -ffreestanding -fsigned-char -fno-move-loop-invariants -Wall --specs=nano.specs --specs=nosys.specs -MMD -MP -DF_CPU=100000000L -DPLATFORMIO=30500 -DTARGET_LPC1768 -DIS_REARM -IMarlin/frameworks/CMSIS/LPC1768/include -IMarlin/frameworks/CMSIS/LPC1768/lib -IMarlin/src/HAL -IMarlin -I.piolibdeps/U8glib-ARM_ID1691/src Marlin/I2CPositionEncoder.cpp
arm-none-eabi-g++ -o .pioenvs/Re-ARM/src/M100_Free_Mem_Chk.o -c -fno-rtti -fno-exceptions -std=gnu++11 -fabi-version=0 -fno-use-cxa-atexit -fno-threadsafe-statics -g -Os -ffunction-sections -fdata-sections -Wall -mthumb -nostdlib -Os -mcpu=cortex-m3 -mthumb -ffreestanding -fsigned-char -fno-move-loop-invariants -Wall --specs=nano.specs --specs=nosys.specs -MMD -MP -DF_CPU=100000000L -DPLATFORMIO=30500 -DTARGET_LPC1768 -DIS_REARM -IMarlin/frameworks/CMSIS/LPC1768/include -IMarlin/frameworks/CMSIS/LPC1768/lib -IMarlin/src/HAL -IMarlin -I.piolibdeps/U8glib-ARM_ID1691/src Marlin/M100_Free_Mem_Chk.cpp
arm-none-eabi-g++ -o .pioenvs/Re-ARM/src/Marlin.o -c -fno-rtti -fno-exceptions -std=gnu++11 -fabi-version=0 -fno-use-cxa-atexit -fno-threadsafe-statics -g -Os -ffunction-sections -fdata-sections -Wall -mthumb -nostdlib -Os -mcpu=cortex-m3 -mthumb -ffreestanding -fsigned-char -fno-move-loop-invariants -Wall --specs=nano.specs --specs=nosys.specs -MMD -MP -DF_CPU=100000000L -DPLATFORMIO=30500 -DTARGET_LPC1768 -DIS_REARM -IMarlin/frameworks/CMSIS/LPC1768/include -IMarlin/frameworks/CMSIS/LPC1768/lib -IMarlin/src/HAL -IMarlin -I.piolibdeps/U8glib-ARM_ID1691/src Marlin/Marlin.cpp
Marlin/Marlin.ino:0:21: fatal error: Arduino.h: No such file or directory
#include <Arduino.h>
^
compilation terminated.
arm-none-eabi-g++ -o .pioenvs/Re-ARM/src/Marlin_main.o -c -fno-rtti -fno-exceptions -std=gnu++11 -fabi-version=0 -fno-use-cxa-atexit -fno-threadsafe-statics -g -Os -ffunction-sections -fdata-sections -Wall -mthumb -nostdlib -Os -mcpu=cortex-m3 -mthumb -ffreestanding -fsigned-char -fno-move-loop-invariants -Wall --specs=nano.specs --specs=nosys.specs -MMD -MP -DF_CPU=100000000L -DPLATFORMIO=30500 -DTARGET_LPC1768 -DIS_REARM -IMarlin/frameworks/CMSIS/LPC1768/include -IMarlin/frameworks/CMSIS/LPC1768/lib -IMarlin/src/HAL -IMarlin -I.piolibdeps/U8glib-ARM_ID1691/src Marlin/Marlin_main.cpp
arm-none-eabi-g++ -o .pioenvs/Re-ARM/src/Sd2Card.o -c -fno-rtti -fno-exceptions -std=gnu++11 -fabi-version=0 -fno-use-cxa-atexit -fno-threadsafe-statics -g -Os -ffunction-sections -fdata-sections -Wall -mthumb -nostdlib -Os -mcpu=cortex-m3 -mthumb -ffreestanding -fsigned-char -fno-move-loop-invariants -Wall --specs=nano.specs --specs=nosys.specs -MMD -MP -DF_CPU=100000000L -DPLATFORMIO=30500 -DTARGET_LPC1768 -DIS_REARM -IMarlin/frameworks/CMSIS/LPC1768/include -IMarlin/frameworks/CMSIS/LPC1768/lib -IMarlin/src/HAL -IMarlin -I.piolibdeps/U8glib-ARM_ID1691/src Marlin/Sd2Card.cpp
arm-none-eabi-g++ -o .pioenvs/Re-ARM/src/SdBaseFile.o -c -fno-rtti -fno-exceptions -std=gnu++11 -fabi-version=0 -fno-use-cxa-atexit -fno-threadsafe-statics -g -Os -ffunction-sections -fdata-sections -Wall -mthumb -nostdlib -Os -mcpu=cortex-m3 -mthumb -ffreestanding -fsigned-char -fno-move-loop-invariants -Wall --specs=nano.specs --specs=nosys.specs -MMD -MP -DF_CPU=100000000L -DPLATFORMIO=30500 -DTARGET_LPC1768 -DIS_REARM -IMarlin/frameworks/CMSIS/LPC1768/include -IMarlin/frameworks/CMSIS/LPC1768/lib -IMarlin/src/HAL -IMarlin -I.piolibdeps/U8glib-ARM_ID1691/src Marlin/SdBaseFile.cpp
*** [.pioenvs/Re-ARM/src/Marlin.o] Error 1
arm-none-eabi-g++ -o .pioenvs/Re-ARM/src/SdFatUtil.o -c -fno-rtti -fno-exceptions -std=gnu++11 -fabi-version=0 -fno-use-cxa-atexit -fno-threadsafe-statics -g -Os -ffunction-sections -fdata-sections -Wall -mthumb -nostdlib -Os -mcpu=cortex-m3 -mthumb -ffreestanding -fsigned-char -fno-move-loop-invariants -Wall --specs=nano.specs --specs=nosys.specs -MMD -MP -DF_CPU=100000000L -DPLATFORMIO=30500 -DTARGET_LPC1768 -DIS_REARM -IMarlin/frameworks/CMSIS/LPC1768/include -IMarlin/frameworks/CMSIS/LPC1768/lib -IMarlin/src/HAL -IMarlin -I.piolibdeps/U8glib-ARM_ID1691/src Marlin/SdFatUtil.cpp
========================== [ERROR] Took 5.76 seconds ==========================
================================== [SUMMARY] ==================================
Environment megaatmega2560  	[SKIP]
Environment megaatmega1280  	[SKIP]
Environment printrboard     	[SKIP]
Environment printrboard_revf	[SKIP]
Environment brainwavepro    	[SKIP]
Environment rambo           	[SKIP]
Environment DUE             	[SKIP]
Environment teensy35        	[SKIP]
Environment Re-ARM          	[ERROR]
========================== [ERROR] Took 5.76 seconds ==========================

@gepd
Copy link
Owner

gepd commented Aug 27, 2017

Wrote for @fiveangle:

fyi... you probably already know this, but I just retested after resolution of the multi-line lib_deps issue and it seems to be moving backwards a bit, as it's now also strippinng comments and swashing multi blank/trailing lines :)

screen shot 2017-08-25 at 8 26 35 pm

@gepd gepd reopened this Aug 27, 2017
@fiveangle
Copy link
Author

the multi-line library issue I reported here is resolved, the platformio.ini corruption issue of #137 remains and has gotten worse, so I'm unsure why you want to track that here rather than on #137

@gepd
Copy link
Owner

gepd commented Sep 5, 2017

Is easier to me, track one topic in a issue at time, than many of them in one.
In this case, the new problem started when I changed the library for this issue, so it's directly related.
I'm currently working in this, because it will solve other related problems too, I think it will be done this week

@fiveangle
Copy link
Author

gotcha, thanks !

@gepd
Copy link
Owner

gepd commented Sep 17, 2017

I had forgot to tell you that this problem is fixed, you can tried installing the developer branch: https://github.com/gepd/Deviot/wiki/Setup#developer

@fiveangle
Copy link
Author

Appears resolved - thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants