allow older Matlab and GNU Octave to work

+stdlib/absolute.m

@@ -17,14 +17,19 @@
 % non-existant path is made absolute relative to pwd
 
 function c = absolute(p, base, expand_tilde, use_java)
-arguments
-  p (1,1) string
-  base (1,1) string = ""
-  expand_tilde (1,1) logical = true
-  use_java (1,1) logical = false
-end
+% arguments
+%   p (1,1) string
+%   base (1,1) string = ""
+%   expand_tilde (1,1) logical = true
+%   use_java (1,1) logical = false
+% end
+if nargin < 2, base = ""; end
+if nargin < 3, expand_tilde = true; end
+if nargin < 4, use_java = false; end
+
+c = pwd();
 
-cwd = stdlib.posix(pwd());
+cwd = stdlib.posix(c);
 
 Lb = stdlib.len(base);
 
@@ -70,5 +75,5 @@
 end
 
 
-%!assert(absolute('', '', 0,0), posix(pwd))
-%!assert(absolute('a/b', '', 0,0), posix(fullfile(pwd, 'a/b')))
+%!assert(absolute('', ''), posix(pwd))
+%!assert(absolute('a/b', ''), posix(fullfile(pwd, 'a/b')))

+stdlib/canonical.m

@@ -14,11 +14,13 @@
 % https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/io/File.html#getCanonicalPath()
 
 function c = canonical(p, expand_tilde, use_java)
-arguments
-  p (1,1) string
-  expand_tilde (1,1) logical = true
-  use_java (1,1) logical = false
-end
+% arguments
+%   p (1,1) string
+%   expand_tilde (1,1) logical = true
+%   use_java (1,1) logical = false
+% end
+if nargin < 2, expand_tilde = true; end
+if nargin < 3, use_java = false; end
 
 if expand_tilde
   c = stdlib.expanduser(p, use_java);
@@ -59,6 +61,6 @@
 
 end
 
-%!assert(canonical("", 0,0), "")
-%!assert(canonical("~",1,0), homedir())
-%!assert(canonical("a/b/..",0,0), "a")
+%!assert(canonical(""), "")
+%!assert(canonical("~"), homedir())
+%!assert(canonical("a/b/.."), "a")

+stdlib/create_symlink.m

@@ -9,18 +9,17 @@
 % Ref: https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/nio/file/Files.html#createSymbolicLink(java.nio.file.Path,java.nio.file.Path,java.nio.file.attribute.FileAttribute...)
 
 function ok = create_symlink(target, link)
-
-arguments
-  target (1,1) string
-  link (1,1) string
-end
+% arguments
+%   target (1,1) string
+%   link (1,1) string
+% end
 
 if stdlib.isoctave()
 
   [err, msg] = symlink(target, link);
   ok = err == 0;
   if ~ok
-    warning("symlink: %s", msg)
+    warning("create_symlink: %s", msg)
   end
 
 elseif ispc || isMATLABReleaseOlderThan("R2024b")
@@ -61,5 +60,5 @@
 
 %!test
 %! if !ispc
-%!   create_symlink(tempname, tempname)
+%!   assert(create_symlink(tempname, tempname))
 %! endif

+stdlib/diskfree.m

@@ -6,9 +6,9 @@
 % Ref: https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/io/File.html#getUsableSpace()
 
 function f = diskfree(d)
-arguments
-  d (1,1) string {mustBeFolder}
-end
+% arguments
+%   d (1,1) string
+% end
 
 if stdlib.isoctave()
   o = javaObject("java.io.File", d);

+stdlib/drop_slash.m

@@ -1,9 +1,9 @@
 %% DROP_SLASH drop repeated and trailing slash
 
 function d = drop_slash(p)
-arguments
-  p (1,1) string
-end
+% arguments
+%   p (1,1) string
+% end
 
 s = stdlib.posix(p);
 
@@ -12,7 +12,7 @@
 
 L = stdlib.len(d);
 
-if d == '/' || ~L
+if strcmp(d, '/') || ~L
   return;
 end
 

+stdlib/exists.m

@@ -7,11 +7,11 @@
 %
 
 function ok = exists(p, use_java)
-arguments
-  p (1,1) string
-  use_java (1,1) logical = false
-end
-
+% arguments
+%   p (1,1) string
+%   use_java (1,1) logical = false
+% end
+if nargin < 2, use_java = false; end
 
 if stdlib.isoctave()
   ok = javaObject("java.io.File", p).exists();

+stdlib/expanduser.m

@@ -8,10 +8,11 @@
 % * e: expanded path
 
 function e = expanduser(p, use_java)
-arguments
-  p (1,1) string
-  use_java (1,1) logical = false
-end
+% arguments
+%   p (1,1) string
+%   use_java (1,1) logical = false
+% end
+if nargin < 2, use_java = false; end
 
 e = stdlib.drop_slash(p);
 
@@ -49,9 +50,9 @@
 end
 
 
-%!assert(expanduser('',0), '')
-%!assert(expanduser("~",0), homedir())
-%!assert(expanduser("~/",0), homedir())
-%!assert(expanduser("~user",0), "~user")
-%!assert(expanduser("~user/",0), "~user")
-%!assert(expanduser("~///c",0), strcat(homedir(), "/c"))
+%!assert(expanduser(''), '')
+%!assert(expanduser("~"), homedir())
+%!assert(expanduser("~/"), homedir())
+%!assert(expanduser("~user"), "~user")
+%!assert(expanduser("~user/"), "~user")
+%!assert(expanduser("~///c"), strcat(homedir(), "/c"))

+stdlib/file_size.m

@@ -1,10 +1,11 @@
 % FILE_SIZE size in bytes of file
 
 function s = file_size(p, use_java)
-arguments
-  p (1,1) string {mustBeFile}
-  use_java (1,1) logical = false
-end
+% arguments
+%   p (1,1) string {mustBeFile}
+%   use_java (1,1) logical = false
+% end
+if nargin < 2, use_java = false; end
 
 if stdlib.isoctave()
   s = javaObject("java.io.File", p).length();

+stdlib/filename.m

@@ -2,9 +2,9 @@
 % filename (including suffix) without directory
 
 function f = filename(p)
-arguments
-  p (1,1) string
-end
+% arguments
+%   p (1,1) string
+% end
 
 % NOT https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/io/File.html#getName()
 % because by our definition, a trailing directory component is not part of the filename

+stdlib/get_pid.m

@@ -2,7 +2,7 @@
 
 function pid = get_pid()
 
-if stdlib.isoctave
+if stdlib.isoctave()
   pid = getpid();
 else
   pid = feature("getpid");

+stdlib/get_shell.m

@@ -2,8 +2,12 @@
 % return value of environment variable SHELL
 % this is mostly relevant on unix-like systems
 
-function shell = get_shell()
+function s = get_shell()
 
-shell = string(getenv("SHELL"));
+s = getenv("SHELL");
+
+try %#ok<TRYNC>
+  s = string(s);
+end
 
 end

+stdlib/h5exists.m

@@ -7,10 +7,10 @@
 % * exists: boolean
 
 function exists = h5exists(file, variable)
-arguments
-  file (1,1) string {mustBeFile}
-  variable (1,1) string
-end
+% arguments
+%   file (1,1) string {mustBeFile}
+%   variable (1,1) string
+% end
 
 exists = false;
 
@@ -19,7 +19,8 @@
   exists = true;
 catch e
   if stdlib.isoctave
-    if ~strfind(e.message, 'does not exist')
+    disp(e.message)
+    if strcmp(e.identifier, "Octave:undefined-function") || isempty(strfind(e.message, 'does not exist'))
       rethrow(e)
     end
   else
@@ -35,7 +36,7 @@
 %! pkg load hdf5oct
 %! fn = 'test_h5exists.h5';
 %! ds = '/a';
-%! delete(fn)
+%! if isfile(fn), delete(fn); end
 %! h5create(fn, ds, [1])
 %! assert(h5exists(fn, ds))
 %! delete(fn)

+stdlib/h5save_exist.m

@@ -32,11 +32,12 @@ function h5save_exist(filename, varname, A, sizeA)
 end
 
 %!test
+%! pkg load hdf5oct
 %! fn = 'test_h5save_exist.h5';
 %! ds = '/a';
 %! a = [1,2];
 %! b = [3,4];
-%! delete(fn)
+%! if isfile(fn), delete(fn); end
 %! h5save_new(fn, ds, a, size(a), 0)
 %! h5save_exist(fn, ds, b, size(b))
 %! assert(h5read(fn, ds), b)

+stdlib/h5save_new.m

@@ -31,10 +31,11 @@ function h5save_new(filename, varname, A, sizeA, compressLevel)
 end
 
 %!test
+%! pkg load hdf5oct
 %! fn = 'test_h5save_new.h5';
 %! ds = '/a';
 %! a = [1,2];
-%! delete(fn)
+%! if isfile(fn), delete(fn); end
 %! h5save_new(fn, ds, a, size(a), 0)
 %! assert(h5read(fn, ds), a)
 %! delete(fn)

+stdlib/h5size.m

@@ -7,10 +7,10 @@
 % fsize: vector of variable size per dimension. Empty if scalar variable.
 
 function fsize = h5size(file, variable)
-arguments
-  file (1,1) string {mustBeFile}
-  variable (1,1) string {mustBeNonzeroLengthText}
-end
+% arguments
+%   file (1,1) string {mustBeFile}
+%   variable (1,1) string {mustBeNonzeroLengthText}
+% end
 
 dsi = h5info(file, variable).Dataspace;
 
@@ -28,7 +28,7 @@
 %! fn = 'test_h5size.h5';
 %! ds = '/a';
 %! a = [1,2];
-%! delete(fn)
+%! if isfile(fn), delete(fn); end
 %! h5save_new(fn, ds, a, size(a), 0)
 %! assert(h5size(fn, ds), uint64([1,2]))
 %! delete(fn)

+stdlib/h5variables.m

@@ -9,12 +9,13 @@
 % * names: variable names
 
 function names = h5variables(file, group)
-arguments
-  file (1,1) string {mustBeFile}
-  group (1,1) string = ""
-end
+% arguments
+%   file (1,1) string {mustBeFile}
+%   group (1,1) string = ""
+% end
+if nargin < 2, group = ""; end
 
-if stdlib.len(group) == 0
+if ~stdlib.len(group)
   finf = h5info(file);
 else
   finf = h5info(file, group);
@@ -23,7 +24,7 @@
 ds = finf.Datasets;
 
 if ischar(file)
-  if isempty(ds) %#ok<UNRCH>
+  if isempty(ds)
     names = [];
   else
     names = {ds.Name};
@@ -43,7 +44,7 @@
 %! pkg load hdf5oct
 %! fn = 'test_h5variables.h5';
 %! ds = '/a';
-%! delete(fn)
+%! if isfile(fn), delete(fn); end
 %! h5create(fn, ds, [1])
 %! assert(h5variables(fn, ''), {'/a'})
 %! delete(fn)

+stdlib/handle2filename.m

@@ -1,14 +1,14 @@
 %% HANDLE2FILENAME Convert a file handle to a filename
 
-function name = handle2filename(fileHandle)
+function n = handle2filename(fileHandle)
 arguments
-    fileHandle (1,1) {mustBeInteger}
+  fileHandle (1,1) {mustBeInteger}
 end
 
 if fileHandle >= 0
-  name = stdlib.posix(fopen(fileHandle));
+  n = stdlib.posix(string(fopen(fileHandle)));
 else
-  name = string.empty;
+  n = string.empty;
 end
 
 end

+stdlib/has_java.m

@@ -11,3 +11,5 @@
 ok = h;
 
 end
+
+%!assert(islogical(has_java()))