-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Street View: Street Smart API support #9878
Merged
allyoucanmap
merged 10 commits into
geosolutions-it:master
from
offtherailz:cyclomedia_sv
Jan 15, 2024
Merged
Street View: Street Smart API support #9878
allyoucanmap
merged 10 commits into
geosolutions-it:master
from
offtherailz:cyclomedia_sv
Jan 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general the implementation looks good. Here an issues while testing locally:
- switch a context from 2D to 3D does not disable the street view component causing inability to interact with point once switch again from 3D to 2D
allyoucanmap
approved these changes
Jan 15, 2024
@ElenaGallo please test this fix on dev, thanks |
12 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the support for Street smart in Street View plugin.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#9877
What is the new behavior?
Fix #9877
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
For reviewer:
The changes consists in 2 macro-areas.
you can distinguish them because street-view plugin changes are all in street-view plugin folder.
Enchanced support for WFS Layer
In order to gather data on Map, the StreetSmart API uses a WFS service with a limited set of functions and functionalities.
In particular it supports:
bbox
ogc filter. Data can not be downloaded all together, so I needed also to support the strategybbox
for downloading only data on the current area, and limit the maxResolution to start downloading only at a certain level of zoom.basic
application/json
For this reason I needed to include a partial support to these properties:
serverType
.no-vendor
: no use of cql_filters, only OGC, and only post requeststartegy
:bbox
(implemented for the moment only forno-vendor
security
: as planned for possible implementation ofbasic
authentication support, this property includes the information about layer security (type: basic, location sessionStorage).These new configs need to be documented.
Effective implementation of StreetSmart in street view
This consists in:
Extending the model
The api has been generalized to allow usage of different providers.
Cyclomedia impelmentation
Initially I tried to use
npm
library (published in december) to implement it. It was working quite well, but conflciting withreact-dnd
of MapStore.To woraround this issue, I switched to a
cdn
load approach in aniframe
. The API is loaded now only in the component. This is possible also because the data retrival uses WFS, so no js api is needed outside the component.For testing
You will need
apiKey
,username
andpassword
Note
This is a first implementation, therefore there is a minimal integration. The tool of the application are not all available, but the minimal integration (street-view) is in place.
Future improvements will allow to use these tools too, after proper investigation.
Some of these tools are disabled and not actually impelmented on MapStore, even they may be available after some investigation.
Some of them are instead not working (even in the viewer test). The "missing" or "not working" errors are shown directly in the viewer UI.
Tools