Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#9840: StreetView plugin ability to set parameters for the default size of panel #9842

Merged
merged 2 commits into from
Jan 8, 2024
Merged

#9840: StreetView plugin ability to set parameters for the default size of panel #9842

merged 2 commits into from
Jan 8, 2024

Conversation

dsuren1
Copy link
Contributor

@dsuren1 dsuren1 commented Dec 20, 2023 •
edited
Loading

Description

This PR introduces a configuration property panelSize to set default size of the street view panel, allowing user to see more info Ex: when configuring panoramaOptions like imageDateControl

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Enhancement

Issue

What is the current behavior?

What is the new behavior?

Screen.Recording.2023-12-20.at.7.21.06.PM.mov

Testing

/context/street-view

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@dsuren1 dsuren1 added enhancement BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch C169-Rennes-Métropole-2023-GeOrchestra4 Phase 4 labels Dec 20, 2023
@dsuren1 dsuren1 added this to the 2023.02.02 milestone Dec 20, 2023
@dsuren1 dsuren1 requested a review from offtherailz December 20, 2023 13:53
@dsuren1 dsuren1 self-assigned this Dec 20, 2023
@dsuren1 dsuren1 linked an issue Dec 20, 2023 that may be closed by this pull request
[StreetView Plugin] ability to set parameters for the size of the default window #9840
Closed
7 tasks
@offtherailz offtherailz enabled auto-merge (squash) January 8, 2024 11:34
@offtherailz offtherailz merged commit 0be639d into geosolutions-it:master Jan 8, 2024
5 checks passed
@tdipisa tdipisa linked an issue Jan 8, 2024 that may be closed by this pull request
[StreetView Plugin] ability to set parameters for the size of the default window (e.g. to display the date of recording). georchestra/mapstore2-georchestra#644
Closed
7 tasks
@offtherailz
Copy link
Member

@ElenaGallo, could you please test this on DEV ? Thank you (by editing a context with custom size? )

@tdipisa
Copy link
Member

tdipisa commented Jan 8, 2024

@ElenaGallo let us know for the backport.

@ElenaGallo
Copy link
Contributor

Test passed, @dsuren1 please backport to 2023.02.xx. Thanks

dsuren1 added a commit to dsuren1/MapStore2 that referenced this pull request Jan 10, 2024
@dsuren1
geosolutions-it#9840: StreetView plugin ability to set parameters for…
0e59e08 
… the default size of panel (geosolutions-it#9842)

(cherry picked from commit 0be639d)
@dsuren1 dsuren1 mentioned this pull request Jan 10, 2024
Merged
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jan 10, 2024
tdipisa pushed a commit that referenced this pull request Jan 10, 2024
@dsuren1
#9840: StreetView plugin ability to set parameters for the default si…
2fa6ef2 
…ze of panel (#9842) (#9863)

(cherry picked from commit 0be639d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offtherailz offtherailz offtherailz approved these changes

Assignees

@dsuren1 dsuren1

Labels
C169-Rennes-Métropole-2023-GeOrchestra4 enhancement Phase 4
Projects
None yet
Milestone
2023.02.02
4 participants
@dsuren1 @offtherailz @tdipisa @ElenaGallo