Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#9783: resolve test review of not hiding zoom icon in tbl widget in case of removing connection from map widget to tbl widget #9818

Merged
merged 1 commit into from
Dec 14, 2023
Merged

#9783: resolve test review of not hiding zoom icon in tbl widget in case of removing connection from map widget to tbl widget #9818

merged 1 commit into from
Dec 14, 2023

Conversation

mahmoudadel54
Copy link
Contributor

Description

  • In dashboard, fix issue of not hiding zoom icon in tbl widget in case of removing connection from map widget to tbl widget

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

#9783

What is the current behavior?
In dashboard, there was an issue of not hiding zoom icon in tbl widget in case of removing connection from map widget to tbl widget
To produce it:

  • add map
  • add table and create a connection with map
  • create a connection from map to the table
  • remove the connection from table widget that connects with map
  • remove the connection from map widget to the table

What is the new behavior?
Zoom icon in table widget in dashboard viewer will hide if user remove the connection from map widget to the table but with the same scenario above.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@mahmoudadel54
geosolutions-it#9783: resolve test review:
c797b75 
Description:
- In dashboard, fix issue of not hiding zoom icon in tbl widget in case of removing connection from map to tbl
- write unit test for the changes
@mahmoudadel54 mahmoudadel54 added this to the 2023.02.02 milestone Dec 14, 2023
@mahmoudadel54 mahmoudadel54 requested a review from MV88 December 14, 2023 14:36
@mahmoudadel54 mahmoudadel54 self-assigned this Dec 14, 2023
@mahmoudadel54 mahmoudadel54 linked an issue Dec 14, 2023 that may be closed by this pull request
Zoom to record also for Parent Table in Dashboards #9783
Closed
6 tasks
@MV88 MV88 added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Dec 14, 2023
@MV88 MV88 modified the milestones: 2023.02.02, 2024.01.00 Dec 14, 2023
@MV88 MV88 removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Dec 14, 2023
@MV88 MV88 merged commit c6abc8b into geosolutions-it:master Dec 14, 2023
6 checks passed
@MV88
Copy link
Contributor

MV88 commented Dec 14, 2023

@ElenaGallo please test it in DEV

@tdipisa tdipisa added BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch and removed BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MV88 MV88 MV88 approved these changes

Assignees

@mahmoudadel54 mahmoudadel54

Labels
C040-COMUNE_GE-2023-CUSTOM-SUPPORT enhancement
Projects
None yet
Milestone
2024.01.00
Development

Successfully merging this pull request may close these issues.

Zoom to record also for Parent Table in Dashboards
3 participants
@mahmoudadel54 @MV88 @tdipisa