-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2023.02.xx] Fix #9624 Point cloud shading options (#9666) #9722
[Backport 2023.02.xx] Fix #9624 Point cloud shading options (#9666) #9722
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just two comment as i've noticed this PR has 2 more files.
in case they are needed i'll Approve
@@ -8,8 +8,9 @@ | |||
|
|||
import React from 'react'; | |||
import Message from '../I18N/Message'; | |||
import InfoPopover from '../widgets/widget/InfoPopover'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is missing in original PR is because stable branch had some missing code due to other PRs not being backported?
@@ -76,6 +76,23 @@ | |||
.background-color-var(@theme-vars[main-bg]); | |||
} | |||
} | |||
.form-group-flex { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is missing in original PR is because stable branch had some missing code due to other PRs not being backported?
@ElenaGallo please test in QA |
Description
Backport for #9666 and #9670
This PR includes options to improve the point cloud shading visualization with additional fixes for 3d tiles options in layer settings
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#9624
What is the new behavior?
This PR adds point cloud shading options
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information