-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#9473 fix longituindal profile issues - marker and dropup style issue #9485
#9473 fix longituindal profile issues - marker and dropup style issue #9485
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The application crashes if the window is too small. (resizing or opening the app with smaller window).
screencast-github.com-2023.09.25-18_14_02.webm
(tested with this https://dev-mapstore.geosolutionsgroup.com/mapstore/#/context/9241_long_profile )
StandardRouter.jsx:86 TypeError: Cannot read properties of null (reading 'offsetTop')
at getOffsetTop (DOMUtil.js:39:21)
at eval (Menu.jsx:66:84)
at commitHookEffectList (react-dom.development.js:21893:26)
at commitPassiveHookEffects (react-dom.development.js:21927:11)
at HTMLUnknownElement.callCallback (react-dom.development.js:362:14)
at Object.invokeGuardedCallbackDev (react-dom.development.js:411:16)
at invokeGuardedCallback (react-dom.development.js:466:31)
at flushPassiveEffectsImpl (react-dom.development.js:25338:7)
at unstable_runWithPriority (scheduler.development.js:815:12)
at runWithPriority$2 (react-dom.development.js:12188:10)
at flushPassiveEffects (react-dom.development.js:25305:12)
at performSyncWorkOnRoot (react-dom.development.js:24163:5)
at eval (react-dom.development.js:12238:24)
at unstable_runWithPriority (scheduler.development.js:815:12)
at runWithPriority$2 (react-dom.development.js:12188:10)
at flushSyncCallbackQueueImpl (react-dom.development.js:12233:7) '\n at ErrorBoundary (webpack://mapstore2/./node_modules/react-error-boundary/dist/commonjs/ErrorBoundary.js?:36:5)\n at div\n at Router (webpack://mapstore2/./node_modules/react-router/es/Router.js?:36:5)\n at ConnectedRouter (webpack://mapstore2/./node_modules/connected-react-router/esm/ConnectedRouter.js?:60:7)\n at ConnectedRouterWithContext (webpack://mapstore2/./node_modules/connected-react-router/esm/ConnectedRouter.js?:158:25)\n at Connect (webpack://mapstore2/./node_modules/react-redux/es/components/connectAdvanced.js?:152:37)\n at IntlProvider (webpack://mapstore2/./node_modules/react-intl/lib/index.es.js?:804:9)\n at Localized (webpack://mapstore2/./web/client/components/I18N/Localized.jsx?:28:5)\n at eval (webpack://mapstore2/./web/client/components/theme/Theme.jsx?:42:5)\n at Connect (webpack://mapstore2/./node_modules/react-redux/es/components/connectAdvanced.js?:152:37)\n at div\n at StandardRouter (webpack://mapstore2/./web/client/components/app/StandardRouter.jsx?:51:5)\n at Connect (webpack://mapstore2/./node_modules/react-redux/es/components/connectAdvanced.js?:152:37)\n at DragDropContextContainer (webpack://mapstore2/./node_modules/react-dnd/lib/DragDropContext.js?:81:5)\n at Provider (webpack://mapstore2/./node_modules/react-redux/es/components/Provider.js?:24:24)\n at StandardApp (webpack://mapstore2/./web/client/components/app/StandardApp.jsx?:78:5)\n at WithExtensions (webpack://mapstore2/./web/client/components/app/withExtensions.js?:50:7)'
overrideMethod @ console.js:213
onError @ StandardRouter.jsx:86
componentDidCatch @ ErrorBoundary.js:57
callback @ react-dom.development.js:23150
callCallback @ react-dom.development.js:13862
commitUpdateEffects @ react-dom.development.js:13900
commitUpdateQueue @ react-dom.development.js:13888
commitLifeCycles @ react-dom.development.js:21998
commitLayoutEffects @ react-dom.development.js:25288
callCallback @ react-dom.development.js:362
invokeGuardedCallbackDev @ react-dom.development.js:411
invokeGuardedCallback @ react-dom.development.js:466
commitRootImpl @ react-dom.development.js:25024
unstable_runWithPriority @ scheduler.development.js:815
runWithPriority$2 @ react-dom.development.js:12188
commitRoot @ react-dom.development.js:24865
finishSyncRender @ react-dom.development.js:24251
performSyncWorkOnRoot @ react-dom.development.js:24223
eval @ react-dom.development.js:12238
unstable_runWithPriority @ scheduler.development.js:815
runWithPriority$2 @ react-dom.development.js:12188
flushSyncCallbackQueueImpl @ react-dom.development.js:12233
flushSyncCallbackQueue @ react-dom.development.js:12221
scheduleUpdateOnFiber @ react-dom.development.js:23601
enqueueSetState @ react-dom.development.js:14029
Component.setState @ react.development.js:335
onResize @ index.js:92
callListenerProxy @ element-resize-detector.js:155
utils.forEach @ collection-utils.js:14
onResizeCallback @ element-resize-detector.js:154
eval @ scroll.js:549
utils.forEach @ collection-utils.js:14
notifyListenersIfNeeded @ scroll.js:548
eval @ scroll.js:516
process @ batch-processor.js:124
processBatch @ batch-processor.js:37
setTimeout (async)
raf @ batch-processor.js:82
requestFrame @ batch-processor.js:83
processBatchAsync @ batch-processor.js:64
addFunction @ batch-processor.js:24
updateDetectorElements @ scroll.js:460
handleScroll @ scroll.js:579
onShrinkScroll @ scroll.js:420
Show 1 more frame
Show less
@ElenaGallo please test in DEV and let us know if we can backport to 2023.02.0xx. |
Test passed, @MV88 please backport to 2023.02.xx. |
…pup style issue (geosolutions-it#9485) * fix longituindal profile issues * fix lint * fix crash if node cannot be found * Update web/client/utils/__tests__/DOMUtil-test.js * Update web/client/utils/__tests__/DOMUtil-test.js --------- Co-authored-by: Lorenzo Natali <[email protected]> # Conflicts: # web/client/epics/longitudinalProfile.js
…#9485) (#9499) * fix longituindal profile issues * fix lint * fix crash if node cannot be found * Update web/client/utils/__tests__/DOMUtil-test.js * Update web/client/utils/__tests__/DOMUtil-test.js --------- Co-authored-by: Lorenzo Natali <[email protected]> # Conflicts: # web/client/epics/longitudinalProfile.js
Description
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
fix #9473
What is the new behavior?
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information