#9466: handling GetFeatureInfo exceptions parameter format configuration #9471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iguration Desription: - put a default format for GFI exceptions - add getIdentifyFlow to catch GFI errors and exceptions
tdipisa
reviewed
Sep 22, 2023
There was a problem hiding this comment.
@mahmoudadel54 it seems the unit test check is failing. Can you please check?
offtherailz
reviewed
Sep 22, 2023
offtherailz
requested changes
Sep 22, 2023
Description: fix unit test failing results, create new unit test for getIdentifyFlow for wms
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
offtherailz
requested review from
tdipisa,
offtherailz and
MV88
and removed request for
MV88
|
sorry I sent my review to this PR in error, but the comment was for another pull request. 🤦 |
add test cases for getIdentifyFlow in wms-test
MV88
requested changes
Sep 26, 2023
edit in wms-test of mapInfo file by adding a unit test for exception
MV88
requested changes
Sep 28, 2023
…g format for mapInfo/wms-test
|
@ElenaGallo Please test it in dev |
|
Test passe, @mahmoudadel54 please backport this to 2023.02.xx. Thanks |
MV88
added
the
BackportNeeded
ElenaGallo
removed
the
BackportNeeded
dsuren1
pushed a commit
to dsuren1/MapStore2
that referenced
this pull request
Dec 7, 2023
giohappy
pushed a commit
that referenced
this pull request
Dec 7, 2023
…ion (#9471) (#9802) Co-authored-by: mahmoud adel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#9466
What is the current behavior?
Some services has no "application/json" into their exception format list. So an exception of "Parameter 'exceptions' contains unacceptable value" shown for the GFI and prevent showing the identify results.
#
#9466
What is the new behavior?
There is no exception related to wrong exception format in GFI and identify works well with all WMS servcies including arcgis services and the identify results shown to user normally.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information