Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9205: Fix - Map details on context map intermittently disappears #9337

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

dsuren1
Copy link
Contributor

@dsuren1 dsuren1 commented Aug 10, 2023

Description

This PR fixes the details plugin intermittently disappearing when loading context map with details linked resource and map template replacing the original map's details

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?

What is the new behavior?

  • Context map with details always loads correctly
  • Context map with details is retained between map template replacement and merge activity

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@allyoucanmap
Copy link
Contributor

LGTM

@allyoucanmap allyoucanmap merged commit 1c385af into geosolutions-it:master Sep 11, 2023
@allyoucanmap allyoucanmap added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Sep 11, 2023
@allyoucanmap
Copy link
Contributor

@ElenaGallo please test this fix on dev and let us know if we can backport on 2023.02.xx, thanks

@ElenaGallo
Copy link
Contributor

Test passed, @dsuren1 please backport to 2023.02.xx, thanks

dsuren1 added a commit to dsuren1/MapStore2 that referenced this pull request Sep 13, 2023
@allyoucanmap allyoucanmap removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug map details plugin contexts - Map Details won't show or intermittently disappears
3 participants