-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: can import geojson files as layer with query params #9276
feat: can import geojson files as layer with query params #9276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks good, thanks @f-necas for the contribution!
Just some general changes below in particular a fix for the missing notification error when the url of a GeoJSON is not valid
Thanks @allyoucanmap for the review. I've made the changes. |
@f-necas there was a temporary problem with the readthedocs so I'll need to close and reopen the PR again to trigger the workflow |
@ElenaGallo please test this enhancement on dev, thanks |
fwiw, went to try this with the link in the PR description, and here it fails:
is the syntax in the sample url valid ? is the geosolutions dev instance deployed with this PR ? |
@landryb, please see the browser console where a 403 is returned. That's the MS proxy that is currently blocking that URL. |
right. blunders damn CORS... |
Description
PR used to import GeoJSON files from query parameters.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#8927
What is the new behavior?
GeoJSON can be imported with an action query parameter.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information