#9085 isNull Filter #9086
Merged
#9085 isNull Filter #9086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offtherailz
commented
Apr 11, 2023
ale-cristofori
added
BackportNeeded
|
target branch for backport of this PR is |
MV88
requested changes
Apr 11, 2023
Comment on lines
625
to
632
| }, { | ||
| attribute: "attributeNull", | ||
| groupId: 1, | ||
| exception: null, | ||
| operator: "=", | ||
| rowId: "1", | ||
| type: "string", | ||
| value: null |
There was a problem hiding this comment.
this seems duplicate of the first
There was a problem hiding this comment.
good catch. Yes it is
| @@ -811,7 +828,24 @@ describe('FilterUtils', () => { | |||
| value: "isNull" | |||
| }] | |||
| }; | |||
| let expected = '<wfs:GetFeature service="WFS" version="2.0" xmlns:wfs="http://www.opengis.net/wfs/2.0" xmlns:fes="http://www.opengis.net/fes/2.0" xmlns:gml="http://www.opengis.net/gml/3.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.opengis.net/wfs/2.0 http://schemas.opengis.net/wfs/2.0/wfs.xsd http://www.opengis.net/gml/3.2 http://schemas.opengis.net/gml/3.2.1/gml.xsd"><wfs:Query typeNames="ft_name_test" srsName="EPSG:4326"><fes:Filter><fes:PropertyIsNull><fes:ValueReference>attributeNull</fes:ValueReference></fes:PropertyIsNull><fes:PropertyIsNull><fes:ValueReference>attributeValid</fes:ValueReference></fes:PropertyIsNull></fes:Filter></wfs:Query></wfs:GetFeature>'; | |||
| let expected = '<wfs:GetFeature service="WFS" version="2.0" ' | |||
There was a problem hiding this comment.
can't you use template string?
There was a problem hiding this comment.
no, or spaces will not be the same.
Co-authored-by: Matteo V. <[email protected]>
offtherailz
commented
Apr 11, 2023
MV88
approved these changes
Apr 11, 2023
|
@ElenaGallo please test in DEV |
offtherailz
added a commit
to offtherailz/MapStore2
that referenced
this pull request
Apr 12, 2023
* WIP fixing isNull filter * Improved fix * Update build/tests.webpack.js * Fixed tests * Fixed lint * Update build/tests.webpack.js Co-authored-by: Matteo V. <[email protected]> * Update web/client/utils/__tests__/FilterUtils-test.js --------- Co-authored-by: Matteo V. <[email protected]>
offtherailz
added a commit
that referenced
this pull request
Apr 12, 2023
ale-cristofori
pushed a commit
that referenced
this pull request
Apr 13, 2023
) * WIP fixing isNull filter * Improved fix * Update build/tests.webpack.js * Fixed tests * Fixed lint * Update build/tests.webpack.js Co-authored-by: Matteo V. <[email protected]> * Update web/client/utils/__tests__/FilterUtils-test.js --------- Co-authored-by: Matteo V. <[email protected]>
12 tasks
ale-cristofori
added a commit
that referenced
this pull request
Apr 13, 2023
) (#9090) * backport C044-2022.02.xx - #9085 changes to the buildConfig calls (#9086) * WIP fixing isNull filter * Improved fix * Update build/tests.webpack.js * Fixed tests * Fixed lint * Update build/tests.webpack.js Co-authored-by: Matteo V. <[email protected]> * Update web/client/utils/__tests__/FilterUtils-test.js --------- Co-authored-by: Matteo V. <[email protected]> * removed temporarily failing tests for missing uitls functions --------- Co-authored-by: Lorenzo Natali <[email protected]> Co-authored-by: Matteo V. <[email protected]> Co-authored-by: Alessandro Cristofori <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #9085
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#9085
What is the new behavior?
Filter with only isNull can be applied.
isNull condition is not ignored anymore.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information