8536 Resolving measure plugin draw conflicts #8678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allyoucanmap
approved these changes
Oct 17, 2022
|
@ElenaGallo please test on dev and let us know if we can backport the PR on the stable branch 2022.02.xx, thanks |
|
Test passed on DEV, @alex-fko please backport to 2022.02.xx. Thanks |
alex-fko
added a commit
to alex-fko/MapStore2
that referenced
this pull request
Oct 17, 2022
…tions-it#8678) (cherry picked from commit e4bbfe7)
tdipisa
pushed a commit
that referenced
this pull request
Oct 17, 2022
alex-fko
added a commit
to alex-fko/MapStore2
that referenced
this pull request
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Measure tool recently was extended to support Cesium viewer and refactored to take advantage of lazy-loading of the components. This led to side effects when Openlayers/Leaflet measure did not enable properly upon tool activation and was not disabled when measure tool is deactivated.
This PR provides minor changes to properly initialize draw mode and deactivate it whenever components are mounted or unmounted.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#8536
What is the new behavior?
Tool is properly activated and deactivated for Openlayers and Leaflet viewers.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information