Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10648: fix FE test failure for - Issue editing multiple fields in MapStore Attribute Table #10654

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

mahmoudadel54
Copy link
Contributor

Description

This PR includes: fix FE tests failure for #10651

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: fix FE failure test

Issue

#10648

What is the current behavior?
There is a FE test failure for 'savePendingFeatureGridChanges' in featuregrid-test.js

What is the new behavior?
FE test is successfully working

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@MV88 MV88 enabled auto-merge (squash) November 6, 2024 10:42
@MV88 MV88 merged commit 2767b5a into geosolutions-it:master Nov 6, 2024
5 checks passed
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this pull request Nov 6, 2024
…le fields in MapStore Attribute Table (geosolutions-it#10654)

* geosolutions-it#10648: fix FE tests failure for savePendingFeatureGridChanges

* geosolutions-it#10648: remove unit test of  'savePendingFeatureGridChanges'
MV88 pushed a commit that referenced this pull request Nov 6, 2024
…tore Attribute Table (#10651) (#10653)

* #10648: Issue editing multiple fields in MapStore Attribute Table (#10651)

* #10648: Issue editing multiple fields in MapStore Attribute Table
Description:
- edit in update wfs-t xml payload in case of multi-edit in each sigle row
- add unit test for 'savePendingFeatureGridChanges'

* #10648: move 'createChangesTransaction' util function from epics/featuregrid to FeatureGridUtils file and a unit test is added for it.

* #10648: handle unit test for 'savePendingFeatureGridChanges'

* #10648: edit jsdoc for util 'createChangesTransaction'

* #10648: fix FE test failure for - Issue editing multiple fields in MapStore Attribute Table (#10654)

* #10648: fix FE tests failure for savePendingFeatureGridChanges

* #10648: remove unit test of  'savePendingFeatureGridChanges'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue editing multiple fields in MapStore Attribute Table
2 participants