-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#10406: remove the 'Change Password' functionality if the logged in user account is managed via LDAP #10407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the logged in user account is managed via LDAP Description: - handle remove 'Change Password' if the logged in user account by adding a cfg 'isUsingLDAP' in localConfig.json file for login plugin and LoginNav component
Closed
3 tasks
…the logged in user account is managed via LDAP Description: - write unit tests
dsuren1
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ElenaGallo Kindly test this change in DEV. Thanks! |
@mahmoudadel54 please backport, I will test it on the Firenze instance. Thanks |
ElenaGallo
added
the
BackportNeeded
Commits provided for an issue need to be backported to the milestone's stable branch
label
Jun 11, 2024
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
Jun 11, 2024
…the logged in user account is managed via LDAP (geosolutions-it#10407) * geosolutions-it#10406: remove the 'Change Password' functionality if the logged in user account is managed via LDAP Description: - handle remove 'Change Password' if the logged in user account by adding a cfg 'isUsingLDAP' in localConfig.json file for login plugin and LoginNav component * geosolutions-it#10406: remove the 'Change Password' functionality if the logged in user account is managed via LDAP Description: - write unit tests
@ElenaGallo |
dsuren1
pushed a commit
that referenced
this pull request
Jun 12, 2024
…ser account is managed via LDAP (#10407) (#10420) * #10406: remove the 'Change Password' functionality if the logged in user account is managed via LDAP Description: - handle remove 'Change Password' if the logged in user account by adding a cfg 'isUsingLDAP' in localConfig.json file for login plugin and LoginNav component * #10406: remove the 'Change Password' functionality if the logged in user account is managed via LDAP Description: - write unit tests
ElenaGallo
removed
the
BackportNeeded
Commits provided for an issue need to be backported to the milestone's stable branch
label
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, a cfg 'isUsingLDAP' is configured for Login plugin in localConfig.json file for handling remove 'Change Password' if the logged in user account and not admin user.
To enable this, the Login plugin in localConfig.json should be like:
{ "name": "Login", "cfg": { "isUsingLDAP": true } }
And for the contexts, in pluginsConfig.json file:
{ "name": "Login", "glyph": "user", "title": "plugins.Login.title", "description": "plugins.Login.description", "defaultConfig": { "isUsingLDAP": true } }
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#10406
What is the current behavior?
#10406
What is the new behavior?
If 'isUsingLDAP' is configured into localConfig, the change password will be hide if = true and user is not admin else it will be shown.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information