Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10406: remove the 'Change Password' functionality if the logged in user account is managed via LDAP #10407

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

mahmoudadel54
Copy link
Contributor

Description

In this PR, a cfg 'isUsingLDAP' is configured for Login plugin in localConfig.json file for handling remove 'Change Password' if the logged in user account and not admin user.

To enable this, the Login plugin in localConfig.json should be like:
{ "name": "Login", "cfg": { "isUsingLDAP": true } }
And for the contexts, in pluginsConfig.json file:
{ "name": "Login", "glyph": "user", "title": "plugins.Login.title", "description": "plugins.Login.description", "defaultConfig": { "isUsingLDAP": true } }

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

#10406

What is the current behavior?
#10406

What is the new behavior?
If 'isUsingLDAP' is configured into localConfig, the change password will be hide if = true and user is not admin else it will be shown.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

…the logged in user account is managed via LDAP

Description:
- handle remove 'Change Password' if the logged in user account by adding a cfg 'isUsingLDAP' in localConfig.json file for login plugin and LoginNav component
…the logged in user account is managed via LDAP

Description:
- write unit tests
@tdipisa tdipisa requested review from dsuren1 and removed request for ale-cristofori June 6, 2024 08:05
@tdipisa tdipisa added this to the 2024.01.02 milestone Jun 6, 2024
Copy link
Contributor

@dsuren1 dsuren1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsuren1 dsuren1 merged commit 0774b09 into geosolutions-it:master Jun 10, 2024
6 checks passed
@dsuren1
Copy link
Contributor

dsuren1 commented Jun 10, 2024

@ElenaGallo Kindly test this change in DEV. Thanks!

@ElenaGallo
Copy link
Contributor

@mahmoudadel54 please backport, I will test it on the Firenze instance. Thanks

@ElenaGallo ElenaGallo added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jun 11, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this pull request Jun 11, 2024
…the logged in user account is managed via LDAP (geosolutions-it#10407)

* geosolutions-it#10406: remove the 'Change Password' functionality if the logged in user account is managed via LDAP
Description:
- handle remove 'Change Password' if the logged in user account by adding a cfg 'isUsingLDAP' in localConfig.json file for login plugin and LoginNav component

* geosolutions-it#10406: remove the 'Change Password' functionality if the logged in user account is managed via LDAP
Description:
- write unit tests
@mahmoudadel54
Copy link
Contributor Author

@mahmoudadel54 please backport, I will test it on the Firenze instance. Thanks

@ElenaGallo
Backport is done --> #10420

dsuren1 pushed a commit that referenced this pull request Jun 12, 2024
…ser account is managed via LDAP (#10407) (#10420)

* #10406: remove the 'Change Password' functionality if the logged in user account is managed via LDAP
Description:
- handle remove 'Change Password' if the logged in user account by adding a cfg 'isUsingLDAP' in localConfig.json file for login plugin and LoginNav component

* #10406: remove the 'Change Password' functionality if the logged in user account is managed via LDAP
Description:
- write unit tests
@ElenaGallo ElenaGallo removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the 'Change Password' functionality if the logged in user account is managed via LDAP
4 participants