#10281: Use Cache Options functionality extended to be applied on all the layers from a service #10349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… applied on all the layers from a service Description: - add the functionality for use cache options for mapviewer, dashboard, geostory, context - add unit tests - add translations
mahmoudadel54
added
New Feature
Closed
10 tasks
MV88
approved these changes
May 23, 2024
| addLayer(layer); | ||
| toggleLayerSelector(false); | ||
| // fetching 'tileGridData' if layer has truthy flag 'remoteTileGrids' and adding the required props to layer object | ||
| let tileGridPromise = layer.type === 'wms' && layer.remoteTileGrids ? getLayerTileMatrixSetsInfo(generateGeoServerWMTSUrl(layer), layer.name, layer) : new Promise((resolve) => resolve(null)); |
|
@ElenaGallo please test it in DEV |
|
@mahmoudadel54 if the custom tile grids are not available for a layer a note does not appear, it is visible only when I click on Update available tile grids. 1.mp4 |
|
@mahmoudadel54 the behavior above reports an inconsistency. In the display tab the correct state should be reported to the user and the layer configured accordingly. If Use remote custom tile grids in catalog is active, I guess you have to perform a WMTS request before adding the layer to the map to verify if the remote custom tile grid definition exists and can be used. Then, the state of the layer should be consistent with this as well as the UI state. |
12 tasks
|
Test passed, @mahmoudadel54 please backport to 2024.01.xx. Thanks |
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
May 27, 2024
…ctionality extended to be applied on all the layers from a service (geosolutions-it#10349)
MV88
pushed a commit
that referenced
this pull request
May 27, 2024
…ed to be applied on all the layers from a service (#10349, #10361) (#10363) * fix conflicts in merging #10281: Use Cache Options functionality extended to be applied on all the layers from a service (#10349) * #10281: Use Cache Options functionality extended to be applied on all the layers from a service (#10361) * #10281: Use Cache Options functionality extended to be applied on all the layers from a service Description: - handle a missing case of showing a warning message in case of not able to fetch the grid sets - add unit tests * fix FE unit test failure #10281 * fix FE unit test failure #10281
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, the functionality for use cache options for mapviewer, dashboard, geostory and context are added. Now user can specify the 'use cache options' from the catalog instead of manually setting in layer settings to activate the tile grid props.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#10281
What is the current behavior?
#10281
What is the new behavior?
Now user can specify the 'use cache options' from the catalog instead of manually setting in layer settings.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information