#10264: Layer visibility limits may prevent the Info panel of search results from opening #10302
Conversation
…anel of search results from opening Description: - isolate getFeature [identify] action from epic 'searchItemSelected' to be applied after zoom and AddMarker events by creating a new epic called 'getFeatureInfoOfSelectedItem' - write unit test for that
dsuren1
added
the
BackportNeeded
|
@ElenaGallo Kindly test it in DEV and let us know if it's good to be backported. Thanks! |
|
@mahmoudadel54 The info panel wont open correctly for a selected search result, If the Visibility limit is set <= 1:4622334. Use this map texas.mp4 |
Hi @dsuren1 @tdipisa The issue is reproduced as for the map mentioned above has the maxZoomLevel = 35 which less than the specified scale for the layer in toc so yes it will zoom based on the maZoomLevel but the features will not be shown so no info will be displayed as it needs more zoom level to be shown and to fetch its GFI
This is the specified layer scale which shows the features on the map |
|
@ElenaGallo please double check you test setup and let us know if the test passes. |
|
@mahmoudadel54 after having better considered the reported issue here during functional tests, I can say there is effectively a missing implementation here. The requirement for covering this specific scenario was effectively envisaged for this cases where the zoom to feature cannot be enough to fit the visibility limit configured. @mahmoudadel54 I kindly ask you to check better the issue definition #10264 where you can see at the end in the other useful information:
That's also a warning for you @dsuren1 who reviewed the PR. |
|
Test passed, @mahmoudadel54 please backport to 2024.01.xx. Thanks |
…anel of search results from opening (geosolutions-it#10302) * geosolutions-it#10264: Layer visibility limits may prevent the Info panel of search results from opening Description: - isolate getFeature [identify] action from epic 'searchItemSelected' to be applied after zoom and AddMarker events by creating a new epic called 'getFeatureInfoOfSelectedItem' - write unit test for that * Update web/client/epics/search.js --------- Co-authored-by: Suren <[email protected]>
Backport is done ---> #10345 |
… Info panel of search results from opening (#10302, #10325) (#10345) * #10264: Layer visibility limits may prevent the Info panel of search results from opening (#10302) * #10264: Layer visibility limits may prevent the Info panel of search results from opening Description: - isolate getFeature [identify] action from epic 'searchItemSelected' to be applied after zoom and AddMarker events by creating a new epic called 'getFeatureInfoOfSelectedItem' - write unit test for that * Update web/client/epics/search.js --------- Co-authored-by: Suren <[email protected]> * #10264: Fix - Layer visibility limits may prevent the Info panel of search results from opening (#10325) * #10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments] Description: - edit featureInfoClick action creator by passing an optional param called 'layerWithIgnoreVisibilityLimits' to enforce it to querable layers if not exist due to visibility limits - handle showing feature info in case of search within single layer or All layers * #10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments] Description: - handle showing feature info in case of action in queryParameters * #10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments] Description: - add missing check on the layer with ignoring visibility limits of making sure it is queryable - fix FE failure test * #10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments] Description: - add unit tests - fix handling search for layers has visibility limits * #10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments] Description: - fix unit test * #10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments] Description: - add reserve to querable layers in identify file to keep the same sort of toc layers in case of 'ignoreVisibilityLimits' - edit unit test based on the change --------- Co-authored-by: Suren <[email protected]>
ElenaGallo
removed
the
BackportNeeded
Description
In this PR, getting the selected search item info is implemented and showing the results into the info [identify] panel even if the layer visibility limit.
the getFeature [identify] action is isolated from epic 'searchItemSelected' into a new epic called 'getFeatureInfoOfSelectedItem' to be applied after zoom and addMarker events just to make sure implementing zoom action first.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#10264
What is the current behavior?
#10264
What is the new behavior?
If the layer has a limited visibility like showing features from a specific scale level, and user searches for an existing feature into the searched layer while the hidden scale level ---> if the feature is existing, it will zoom to this feature and opening the info panel showing the feature info data
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information