Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9999 Measures distance and area now supports all operations as geodesics features #10010

Merged
merged 7 commits into from
Mar 7, 2024

Conversation

MV88
Copy link
Contributor

@MV88 MV88 commented Mar 1, 2024

Description

lines and areas are now geodesic

  • in export as geojson
  • in created as annotations and export and import there

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

Fix #9999

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

Copy link
Contributor

@allyoucanmap allyoucanmap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline comments are addressing mainly some issues with the style parsers.
The workflow for import/export of geodesic annotation is working well.
Also the export of geodesic measurement is working as expected probably the only part missing is to improve the import of geojson to intercept if the feature collections has some features with originalGeom and restore it (geoJSONToLayer used by processFiles). Maybe we could add some custom properties to feature collection eg "msType": "measure" as we are doing for annotation to focus the parsing only on this type of imported layers

@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Mar 5, 2024
@MV88
Copy link
Contributor Author

MV88 commented Mar 6, 2024

Inline comments are addressing mainly some issues with the style parsers. The workflow for import/export of geodesic annotation is working well. Also the export of geodesic measurement is working as expected probably the only part missing is to improve the import of geojson to intercept if the feature collections has some features with originalGeom and restore it (geoJSONToLayer used by processFiles). Maybe we could add some custom properties to feature collection eg "msType": "measure" as we are doing for annotation to focus the parsing only on this type of imported layers

@tdipisa @allyoucanmap
i think this should be a dedicated issue, also because it requires to apply some different styling when the measures is created as vector layer and also when exported as geojson and then needs to be handled also in import

@MV88 MV88 requested a review from allyoucanmap March 7, 2024 09:15
Copy link
Contributor

@allyoucanmap allyoucanmap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allyoucanmap allyoucanmap merged commit ff421f5 into geosolutions-it:master Mar 7, 2024
6 checks passed
@allyoucanmap
Copy link
Contributor

@ElenaGallo please test on dev and let us know if we can backport to 2024.01.xx, thanks

@ElenaGallo
Copy link
Contributor

@MV88 I don't know if the problem is due to this PR but when a measurement is transformed into an annotation and the coordinates change then the style of the text is no longer correct.

measure_into_annotation.mp4

@MV88
Copy link
Contributor Author

MV88 commented Mar 8, 2024

@tdipisa @ElenaGallo
This issue was present also before my PR, I guess we need to open a dedicated issue

@tdipisa
Copy link
Member

tdipisa commented Mar 8, 2024

Wait @ElenaGallo

This issue was present also before my PR, I guess we need to open a dedicated issue

@MV88 I tried and it doesn't seems to me at the moment. Let's check it together before opening a new issue.

@tdipisa
Copy link
Member

tdipisa commented Mar 8, 2024

Ok, that's more clear now what is the problem: the length measurement text/style of the last segment is changing after modifying one vertex. The image below better clarify before and after @ElenaGallo

image

@ElenaGallo that's a preexisting issue, please open a new issue for that for 2024.01.00 and assign it to @MV88. Then, let us know if we can proceed with the backport of this to 2024.01.xx.

@ElenaGallo
Copy link
Contributor

@tdipisa New issue #10051, @MV88 please backport this PR to 2024.01.xx. Thanks

MV88 added a commit to MV88/MapStore2 that referenced this pull request Mar 12, 2024
MV88 added a commit that referenced this pull request Mar 12, 2024
@ElenaGallo ElenaGallo removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Mar 12, 2024
offtherailz pushed a commit to offtherailz/MapStore2 that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geodesic Measurement export
4 participants