-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #9999 Measures distance and area now supports all operations as geodesics features #10010
Conversation
…ations as geodeics features
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inline comments are addressing mainly some issues with the style parsers.
The workflow for import/export of geodesic annotation is working well.
Also the export of geodesic measurement is working as expected probably the only part missing is to improve the import of geojson to intercept if the feature collections has some features with originalGeom and restore it (geoJSONToLayer used by processFiles). Maybe we could add some custom properties to feature collection eg "msType": "measure" as we are doing for annotation to focus the parsing only on this type of imported layers
@tdipisa @allyoucanmap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ElenaGallo please test on dev and let us know if we can backport to 2024.01.xx, thanks |
@MV88 I don't know if the problem is due to this PR but when a measurement is transformed into an annotation and the coordinates change then the style of the text is no longer correct. measure_into_annotation.mp4 |
@tdipisa @ElenaGallo |
Wait @ElenaGallo
@MV88 I tried and it doesn't seems to me at the moment. Let's check it together before opening a new issue. |
Ok, that's more clear now what is the problem: the length measurement text/style of the last segment is changing after modifying one vertex. The image below better clarify before and after @ElenaGallo @ElenaGallo that's a preexisting issue, please open a new issue for that for 2024.01.00 and assign it to @MV88. Then, let us know if we can proceed with the backport of this to 2024.01.xx. |
…operations as geodesics features (geosolutions-it#10010)
…operations as geodesics features (geosolutions-it#10010)
Description
lines and areas are now geodesic
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
Fix #9999
What is the new behavior?
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information