Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background selector in contexts won't retain thumbnail in view mode #9702

Closed
ale-cristofori opened this issue Nov 14, 2023 · 1 comment · Fixed by #9720 or #9744
Closed

Background selector in contexts won't retain thumbnail in view mode #9702

ale-cristofori opened this issue Nov 14, 2023 · 1 comment · Fixed by #9720 or #9744

Comments

@ale-cristofori
Copy link
Contributor

ale-cristofori commented Nov 14, 2023

Reproduction steps

  1. Open this context in edit mode. Observe that the BG layer thumbnail for Ortofoto Regione Piemonte is visible on the BG selector plugin. The service was imported when the context was created.
    Image

  2. Open the same context in view mode, observe that the thumbnail is not there, and there is the warning message Preview Not Available.
    Image

  3. Save the context as map, obeserve that on the created map the BG thumbnail becomes visible again
    Image

The expected behaviour would be to see visible the BG layer thumbnail in the BG selector in the context in edit view, point 2.

@dsuren1
Copy link
Contributor

dsuren1 commented Nov 20, 2023

Investigation outcome

Context not showing thumbnails is due to a race condition in the loading phase of map and context configurations. The thumbnails are parsed and layer object is updated with an epic included inside the Background plugin. But the loading of context plugin starts only after the loading of map configuration, so sometimes the epic is not ready in time to listen to MAP_CONFIG_LOADED action.
We can solve this by including the epic that parses thumbnail in the core config workflow of map initialization

dsuren1 added a commit to dsuren1/MapStore2 that referenced this issue Nov 21, 2023
@MV88 MV88 added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 22, 2023
MV88 added a commit that referenced this issue Nov 22, 2023
…n view mode (#9720)

* #9702: Fix - Background selector in contexts won't retain thumbnail in view mode

* Update web/client/epics/config.js

---------

Co-authored-by: Matteo V <[email protected]>
@ElenaGallo ElenaGallo self-assigned this Nov 22, 2023
dsuren1 added a commit to dsuren1/MapStore2 that referenced this issue Nov 24, 2023
@ElenaGallo ElenaGallo added Accepted and removed BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Nov 24, 2023
tdipisa pushed a commit that referenced this issue Nov 27, 2023
* Fix #9624 Point cloud shading options (#9666)

* Fix #9666 Include pointCloudShading option to saved layer config (#9670)

* #9606 Error with circle annotations + radius selection (#9607) (#9727)

Co-authored-by: Diego Vargas <[email protected]>

* Fix #9295 added better handling of format in csw service (#9712) (#9732)

* #9702: Fix - Background selector in contexts won't retain thumbnail in view mode (#9720) (#9744)

* #9567: handle functionality of zoom to record in table widgets (#9608)

* #9567: handle functionality of zoom to record in table widgets

* Fix: Correct failing test cases for zoom records issue in table widgets (#9567)
This commit addresses the failing test cases related to the issue of zoom records in table widgets.
* #9567: implement the new approach in zoom to records in table widgets + writing unit tests
* #9567: handle adding flag into config file to show/hide zoom icon for tblWidget
* #9567: reset flag enableZoomInTblWidget to be true for dashboard and map viewer
* #9567: resolve comments' review:
- put flag of zoomInTblWidget as a default prop
- add translations
- edit zoomToExtent enhancer to use internal zoom
- remove selector "getFlagOfShowingTblWidgetZoom " and use plugin prop instead

* #9683: add Details Panel for MS dashboard (#9689)

* #9683: add Details Panel for MS dashboard
-  The tool have the same options (eg. show as modal, show at startup etc.)
- The tool is defined in the same way of the corresponding one for maps.
- Edit the layout to put add widget & show/hide connection buttons to the sidebar menu

* #9683: resolve the FE test

Update DashboardEditor.jsx

* #9683: resolve review comments
* description:
- remove all dashboard selectors and pieces of code in generic components like sidebar plugin component that relevant to dashboard.
- add missing test for detailsLoaded action
- create new selectors, details uri selector and details settings se;ector that are used in many places in code
- move AddWidgetDashboard, MapConnedctionDashboard plugins to direct plugins folder
- Put global spinner in details plugin and remove it from sidebar plugin
-  edit in handleSave enhancer file to make update attributes of details just implemented for Map and Dashboard
- Add custom style in details.less as the lib of react-dock doesn't allow to override left css property
- remove unused added style from panels.less

* #9683: remove unused comments in dashboard-test file

* #9683: edit in details epics and selectors to fix FE test

* #9683: Resolve review comments
Description:
- Reolve unused loading property from DashoardEditor file
- Add tooltip for save dashboard
- Remove custom style in BorderLayout and leave it with generic style

* #9683: resolve review comments
Description:
- edit navbar.less files to fix going language selector behind body panel
- remove unused z-index in dashboard.less
# Conflicts:
#	web/client/epics/__tests__/config-test.js
#	web/client/epics/config.js

* #9683: resolve test comment (#9730)

- Adding export, import, delete dashboard
- Reorder shown plugins in sidebar for dashboard

* #9683: add Details Panel for MS dashboard [Editing the detail panel tooltip and title]  (#9740)

* #9683: resolve test comment
Description:
- edit the detail panel tooltip and shown title and make it generic one
- Add translations for the new tooltip

* Update web/client/translations/data.it-IT.json

---------

Co-authored-by: Matteo V <[email protected]>

* #9728 fix misalignement issue (#9731) (#9742)

* Fix #9729 fixed formats in catalog used in dashboard (#9733) (#9747)

---------

Co-authored-by: stefano bovio <[email protected]>
Co-authored-by: Diego Vargas <[email protected]>
Co-authored-by: Suren <[email protected]>
Co-authored-by: mahmoud adel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment