Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geo processing tool - Advanced Settings options issue #9474

Closed
ElenaGallo opened this issue Sep 22, 2023 · 2 comments · Fixed by #9493 or #9495
Closed

Geo processing tool - Advanced Settings options issue #9474

ElenaGallo opened this issue Sep 22, 2023 · 2 comments · Fixed by #9493 or #9495

Comments

@ElenaGallo
Copy link
Contributor

Description

In Advanced Settings, the option names are incorrect and are not translated correctly.

translation.mp4

Other useful information

Related to #9351 (comment)

@MV88
Copy link
Contributor

MV88 commented Sep 25, 2023

this is not an issue, it was intentional to define the label with the name of the parameter to be used later.

it was requested in review, reporting the content of the comment here

image

image

@MV88 MV88 closed this as completed Sep 25, 2023
@tdipisa
Copy link
Member

tdipisa commented Sep 25, 2023

@MV88 properties names should be reported consistently as they are intended on the WPS side and properly translated. In EN we have to use the following:

First attributes to retain
Second attributes to retain
Intersection mode
Percentages enabled
Areas enabled

each of them should be properly translated in supported languages (the description already provide the meaning).

MV88 added a commit to MV88/MapStore2 that referenced this issue Sep 26, 2023
tdipisa added a commit that referenced this issue Sep 26, 2023
* Fix #9474 adjusted geo processing locales

* Update web/client/translations/data.en-US.json

Co-authored-by: Tobia Di Pisa <[email protected]>

* Update web/client/translations/data.fr-FR.json

Co-authored-by: Tobia Di Pisa <[email protected]>

* Update web/client/translations/data.it-IT.json

Co-authored-by: Tobia Di Pisa <[email protected]>

* Update web/client/translations/data.it-IT.json

Co-authored-by: Tobia Di Pisa <[email protected]>

* Update web/client/translations/data.fr-FR.json

Co-authored-by: Tobia Di Pisa <[email protected]>

---------

Co-authored-by: Tobia Di Pisa <[email protected]>
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Sep 26, 2023
MV88 added a commit to MV88/MapStore2 that referenced this issue Sep 26, 2023
…s-it#9493)

* Fix geosolutions-it#9474 adjusted geo processing locales

* Update web/client/translations/data.en-US.json

Co-authored-by: Tobia Di Pisa <[email protected]>

* Update web/client/translations/data.fr-FR.json

Co-authored-by: Tobia Di Pisa <[email protected]>

* Update web/client/translations/data.it-IT.json

Co-authored-by: Tobia Di Pisa <[email protected]>

* Update web/client/translations/data.it-IT.json

Co-authored-by: Tobia Di Pisa <[email protected]>

* Update web/client/translations/data.fr-FR.json

Co-authored-by: Tobia Di Pisa <[email protected]>

---------

Co-authored-by: Tobia Di Pisa <[email protected]>
tdipisa added a commit that referenced this issue Sep 26, 2023
* Fix #9474 adjusted geo processing locales

* Update web/client/translations/data.en-US.json



* Update web/client/translations/data.fr-FR.json



* Update web/client/translations/data.it-IT.json



* Update web/client/translations/data.it-IT.json



* Update web/client/translations/data.fr-FR.json



---------

Co-authored-by: Tobia Di Pisa <[email protected]>
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment