Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advanced map editing in geostory crashes the app #9434

Closed
1 task done
allyoucanmap opened this issue Sep 13, 2023 · 3 comments · Fixed by #9457 or #9477
Closed
1 task done

Advanced map editing in geostory crashes the app #9434

allyoucanmap opened this issue Sep 13, 2023 · 3 comments · Fixed by #9457 or #9477
Assignees
@dsuren1 @ElenaGallo
Labels
Accepted bug C027-COMUNE_FI-2023-SUPPORT investigation
Milestone
2023.02.00

Comments

@allyoucanmap
Copy link
Contributor

Description

geostory-advanced-editor-bug.mp4

How to reproduce

  • login
  • create a new geostory
  • add a map as background of a section
  • edit map configuration
  • click on advanced editing option

Expected Result

Advanced editing is working

Current Result

Application crashes (grey screen)

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information
@allyoucanmap allyoucanmap added this to the 2023.02.00 milestone Sep 13, 2023
@tdipisa tdipisa removed their assignment Sep 15, 2023
@dsuren1
Copy link
Contributor

dsuren1 commented Sep 15, 2023 •
edited
Loading

Investigation

  • The error seems to happens only when editing context map

  • As of react-redux v6, context is treated as reserved prop. Hence passing context as part of props to connected component causes the application to crash with following error

    image image

Solution

Omit context props being passed through, as is not needed anyway here. Currently this happens only in geostory, so the fix can be limited to geostory for now.

dsuren1 added a commit to dsuren1/MapStore2 that referenced this issue Sep 15, 2023
@dsuren1
geosolutions-it#9434: Fix - Advanced map editing in geostory crashes …
e016577 
…the app
@dsuren1 dsuren1 mentioned this issue Sep 15, 2023
Merged
5 tasks
@dsuren1 dsuren1 linked a pull request Sep 15, 2023 that will close this issue
#9434: Fix - Advanced map editing in geostory crashes the app #9457
Merged
5 tasks
@tdipisa
Copy link
Member

tdipisa commented Sep 15, 2023

@dsuren1 can you please confirm this problem is also present in QA now?

@dsuren1
Copy link
Contributor

dsuren1 commented Sep 18, 2023

@tdipisa Yes, the issue exists also in QA

@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Sep 18, 2023
MV88 pushed a commit that referenced this issue Sep 18, 2023
@dsuren1
#9434: Fix - Advanced map editing in geostory crashes the app (#9457)
4a9de8e
@ElenaGallo ElenaGallo self-assigned this Sep 22, 2023
dsuren1 added a commit to dsuren1/MapStore2 that referenced this issue Sep 25, 2023
@dsuren1
geosolutions-it#9434: Fix - Advanced map editing in geostory crashes …
693ad18 
…the app (geosolutions-it#9457)

(cherry picked from commit 4a9de8e)
(cherry picked from commit 301c533e7735499213328e85b2c23bfe8669b321)
@dsuren1 dsuren1 mentioned this issue Sep 25, 2023
Merged
@dsuren1 dsuren1 linked a pull request Sep 25, 2023 that will close this issue
[Backport 2023.02.xx] #9434: Fix - Advanced map editing in geostory crashes the app (#9457) #9477
Merged
tdipisa pushed a commit that referenced this issue Sep 25, 2023
@dsuren1
#9434: Fix - Advanced map editing in geostory crashes the app (#9457) (…
0088d71 
…#9477)

(cherry picked from commit 4a9de8e)
(cherry picked from commit 301c533e7735499213328e85b2c23bfe8669b321)
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Sep 25, 2023
@ElenaGallo ElenaGallo linked a pull request Sep 26, 2023 that will close this issue
New Update User Guide - Geoprocessing Tools section #9496
Closed
@ElenaGallo ElenaGallo removed a link to a pull request Sep 26, 2023
New Update User Guide - Geoprocessing Tools section #9496
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsuren1 dsuren1

@ElenaGallo ElenaGallo

Labels
Accepted bug C027-COMUNE_FI-2023-SUPPORT investigation
Projects
None yet
Milestone
2023.02.00
4 participants
@tdipisa @allyoucanmap @dsuren1 @ElenaGallo