Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review styling symbolizer to support missing annotations rules #9355

Closed
1 task done
Tracked by #9094
allyoucanmap opened this issue Aug 24, 2023 · 0 comments · Fixed by #9356
Closed
1 task done
Tracked by #9094

Review styling symbolizer to support missing annotations rules #9355

allyoucanmap opened this issue Aug 24, 2023 · 0 comments · Fixed by #9356
Assignees
@allyoucanmap @ElenaGallo
Labels
3D All issues related to the 3D rendering in CesiumJs Accepted annotations related to the annotation tool C027-COMUNE_FI-2023-SUPPORT enhancement
Milestone
2024.01.00

Comments

@allyoucanmap
Copy link
Contributor

allyoucanmap commented Aug 24, 2023 •
edited
Loading

Description

The vector style used by default vector layer should be updated to support missing properties supported by Annotations style:

  • Circle symbolizer
  • Extend mark symbolizer with custom svg symbols
  • Support of default icon + font awesome glyph in icon symbolizer
  • Add anchor rule for Icon and Text symbolizer
  • Add dash array property to Fill, Mark and Circle symbolizers

The aim of the issue is to close the gap between the default vector style and the annotation style in order to have a single way to stylize features

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features

Other useful information
@allyoucanmap allyoucanmap mentioned this issue Aug 24, 2023
Closed
@allyoucanmap allyoucanmap added enhancement annotations related to the annotation tool 3D All issues related to the 3D rendering in CesiumJs C027-COMUNE_FI-2023-SUPPORT labels Aug 24, 2023
@allyoucanmap allyoucanmap self-assigned this Aug 24, 2023
@allyoucanmap allyoucanmap added this to the 2023.02.00 milestone Aug 24, 2023
@allyoucanmap allyoucanmap mentioned this issue Aug 24, 2023
Merged
5 tasks
@allyoucanmap allyoucanmap linked a pull request Aug 24, 2023 that will close this issue
#9355 Review styling symbolizer to support missing annotations rules #9356
Merged
5 tasks
@tdipisa tdipisa modified the milestones: 2023.02.00, 2024.01.00 Aug 30, 2023
allyoucanmap added a commit that referenced this issue Aug 31, 2023
@allyoucanmap @offtherailz
#9355 Review styling symbolizer to support missing annotations rules (#…
9dcc444 
…9356)

* add support for circle symbolizer

* add possibility to extend mark symbolizer with svg

* add circle to vector layer legend

* add support of marker in icon symbolizer

* add anchor point for icon and text symbolizer in vector style

* add dash array style for mark, fill and circle symbolizers

* add translations

* update documentation

* add tests

* Update web/client/components/styleeditor/RulesEditor.jsx

Co-authored-by: Lorenzo Natali <[email protected]>

* Update web/client/components/styleeditor/MarkerIconSelector.jsx

Co-authored-by: Lorenzo Natali <[email protected]>

* Update web/client/components/styleeditor/MarkSelector.jsx

Co-authored-by: Lorenzo Natali <[email protected]>

* Update web/client/components/styleeditor/MarkSelector.jsx

Co-authored-by: Lorenzo Natali <[email protected]>

* Update web/client/components/styleeditor/RulesEditor.jsx

Co-authored-by: Lorenzo Natali <[email protected]>

* fixes for review

* Added to mkdocs the new file

---------

Co-authored-by: Lorenzo Natali <[email protected]>
@ElenaGallo ElenaGallo self-assigned this Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allyoucanmap allyoucanmap

@ElenaGallo ElenaGallo

Labels
3D All issues related to the 3D rendering in CesiumJs Accepted annotations related to the annotation tool C027-COMUNE_FI-2023-SUPPORT enhancement
Projects
None yet
Milestone
2024.01.00
Development

Successfully merging a pull request may close this issue.

#9355 Review styling symbolizer to support missing annotations rules allyoucanmap/MapStore2
3 participants
@tdipisa @allyoucanmap @ElenaGallo