-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include editing support to allowed user groups #9179
Labels
Milestone
Comments
This was referenced May 17, 2023
dsuren1
added a commit
to dsuren1/MapStore2
that referenced
this issue
Jun 5, 2023
6 tasks
6 tasks
Will be applicable when #9180 is implemented |
Updates
|
tdipisa
pushed a commit
that referenced
this issue
Jun 7, 2023
offtherailz
pushed a commit
that referenced
this issue
Jun 21, 2023
* Code refactor * Unit tests corrected * Permission hierarchy updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Description
As discussed and agreed with #7636 it is required to allow certain editing functionalities depending on the groups the user belongs to.
At the moment the editingAllowedRoles configuration property is available for FeatureEditor and StyleEditor tools to allow users to use the editing functionality depending on their role (ADMIN or USER) by disabling the pencil icon if the user belongs to a role not granted.
It is necessary to extend this system to allow editing functions to users also according to the groups they belong to.
Acceptance criteria
The support for a new configuration property named editingAllowedGroups will be included
That new property can work together with the existing one. For example:
That new property will be supported everywhere the existing editingAllowedRoles is managed in the MS code base (that means for both FeatureEditor and StyleEditor)
Both properties should be probably prioritized somehow to properly catch special cases. For example an ADMIN user should be always allowed independently of the group he belongs to. Therefore editingAllowedGroups should be applied only to users with USER role
The editing functionality of the Attribute Table (plugins.FeatureEditor) can be reached also from the Identify tool if its
cfg.showEdit
property is set to true. That case should be managed accordingly (eg. the pencil icon in Identify panel not available) according the role/group permission rules defined for the plugins.FeatureEditor tool (there is already a control in the Identify plugin to check, looking at the Attribute Table state, if the user is allowed or not)If the Disable editing with Attribute Table property is set to True for a layer the editing function in Attribute Table will be disabled at all independently of the value editingAllowedRoles and editingAllowedGroups. ADMIN users can do everything as usual anyway
Other useful information
See also #9180
The text was updated successfully, but these errors were encountered: