Map Sync issue

[tdipisa]

Description

The map sync issue seems to not work as expected.

How to reproduce

Expected Result

If activated it should remain active after using the Advanced Search in theory. If active by default, there should not be the need to click twice to put in sync the map.

Current Result

• If enabled by default, you need to click twice on it to put in sync the map.

• If not enabled by default when you toggle it then it is toggled off as soon ad a filter is defined with the Advanced Search. It looks like not expected, is this a behavior introduced for some reason?

• Not browser related

Browser info

(use this site: https://www.whatsmybrowser.org/ for non expert users)

Browser Affected	Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information

[allyoucanmap]

It looks like not expected, is this a behavior introduced for some reason?

There are some changes applied in the past to the feature grid that are causing this unexpected behaviors, in particular following PRs:

• #6076: Deactivate MapSync featuregrid close #6155 this PR introduced a behavior that deactivates the map sync every time the feature grid has been closed, this include also when the advanced filter is enabled (at that point the feature grid is closed)
• #8535: Additional improvement on the main bundle #8531 this PR introduced some changes on the structure of the feature editor plugin, in particular the asynchronous import of the grid when the component is actually open. This update changes the way this component mount/unmount affecting the setSyncTool that represents the initialization of the map sync.

We should review the workflow of the map sync tool focusing on following steps:

• do not deactivate the map filter every time the feature grid has been closed but instead improve the isSyncWmsActive selector to be true only if the feature grid is open:
  • remove the deactivateSyncWmsFilterOnFeatureGridClose epic and
  • change selector to eg. export const isSyncWmsActive = (state) => state?.featuregrid?.open && get(state, "query.syncWmsFilter", false);
• review how we store the enableMapFilterSync cfg in the state. We should not update this property every time but only when we open the feature grid from the TOC toolbar (it should be the LAYERS:BROWSE_DATA)
• finally we need to ensure that the map sync functionality is working and consistent with the state button in the toolbar so we need to initialize it every time we open the feature grid if the map sync is enabled in the state, something like this:

export const activateSyncWmsFilterOnFeatureGridOpen = (action$, store) =>
    action$.ofType(OPEN_FEATURE_GRID)
        .filter(() => isSyncWmsActive(store.getState()))
        .switchMap(() => {
            return Rx.Observable.of(startSyncWMS());
        });

All the above codes is part of an investigation so it needs to be verified and validated during the development