Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The measure tool is not opened properly if Measure plugin has 'showCoordinateEditor' with true into cfg.defaultOptions #10424

Closed
1 task done
mahmoudadel54 opened this issue Jun 12, 2024 · 0 comments · Fixed by #10428 or #10440
Closed
1 task done

The measure tool is not opened properly if Measure plugin has 'showCoordinateEditor' with true into cfg.defaultOptions #10424

mahmoudadel54 opened this issue Jun 12, 2024 · 0 comments · Fixed by #10428 or #10440
Assignees
@ElenaGallo @mahmoudadel54
Labels
Accepted bug C125-AUSTROCONTROL-2024-MapStore
Milestone
2024.01.02

Comments

@mahmoudadel54
Copy link
Contributor

mahmoudadel54 commented Jun 12, 2024 •
edited
Loading

By clicking the measure button, the tool does not open properly if the Measure plugin contain 'showCoordinateEditor
' with true info its cfg.defaultOptions

Image

How to reproduce

  • Open a map
  • Click on Measure

Expected Result

The measure tool opens
Current Result

The measure tool is not opened

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information

](https://github.com/geosolutions-it/austrocontrol-C125/issues/357#issuecomment-2162912931)
@mahmoudadel54 mahmoudadel54 added this to the 2024.01.02 milestone Jun 12, 2024
@mahmoudadel54 mahmoudadel54 self-assigned this Jun 12, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jun 14, 2024
@mahmoudadel54
geosolutions-it#10424: The measure tool is not opened properly if Mea…
bf22c74 
…sure plugin has 'showCoordinateEditor' with true into cfg.defaultOptions

Description:
- fix UI issue in measure
@mahmoudadel54 mahmoudadel54 mentioned this issue Jun 14, 2024
Merged
12 tasks
@mahmoudadel54 mahmoudadel54 linked a pull request Jun 14, 2024 that will close this issue
#10424: The measure tool is not opened properly if Measure plugin has 'showCoordinateEditor' with true into cfg.defaultOptions #10428
Merged
12 tasks
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jun 20, 2024
@mahmoudadel54
geosolutions-it#10424: The measure tool is not opened properly if Mea…
7a23713 
…sure plugin has 'showCoordinateEditor' with true into cfg.defaultOptions

Description:
- resolve review comments [change the added class name + handle all mentioned cases]
- add unit test
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jun 20, 2024
@mahmoudadel54
geosolutions-it#10424: The measure tool is not opened properly if Mea…
357cc90 
…sure plugin has 'showCoordinateEditor' with true into cfg.defaultOptions

Description:
- add unit test
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jun 20, 2024
@mahmoudadel54
geosolutions-it#10424: The measure tool is not opened properly if Mea…
2cd195b 
…sure plugin has 'showCoordinateEditor' with true into cfg.defaultOptions

Description:
-change the added class name to a more generic name
allyoucanmap pushed a commit that referenced this issue Jun 21, 2024
@mahmoudadel54
#10424: The measure tool is not opened properly if Measure plugin has…
7443a48 
… 'showCoordinateEditor' with true into cfg.defaultOptions (#10428)
@ElenaGallo ElenaGallo self-assigned this Jun 21, 2024
@ElenaGallo ElenaGallo added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jun 21, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jun 21, 2024
@mahmoudadel54
geosolutions-it#10424: The measure tool is not opened properly if Mea…
5dc37fd 
…sure plugin has 'showCoordinateEditor' with true into cfg.defaultOptions (geosolutions-it#10428)
@mahmoudadel54 mahmoudadel54 mentioned this issue Jun 21, 2024
Merged
@mahmoudadel54 mahmoudadel54 linked a pull request Jun 21, 2024 that will close this issue
[Backport 2024.01.xx]: #10424: The measure tool is not opened properly if Measure plugin has 'showCoordinateEditor' with true into cfg.defaultOptions (#10428) #10440
Merged
tdipisa pushed a commit that referenced this issue Jun 25, 2024
@mahmoudadel54
#10424: The measure tool is not opened properly if Measure plugin has…
52e88d9 
… 'showCoordinateEditor' with true into cfg.defaultOptions (#10428) (#10440)
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaGallo ElenaGallo

@mahmoudadel54 mahmoudadel54

Labels
Accepted bug C125-AUSTROCONTROL-2024-MapStore
Projects
None yet
Milestone
2024.01.02
3 participants
@tdipisa @ElenaGallo @mahmoudadel54