Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scale selector to make it compatible with different projections #10322

Closed
1 task done
offtherailz opened this issue May 14, 2024 · 0 comments · Fixed by #10344 or #10452
Closed
1 task done

Fix scale selector to make it compatible with different projections #10322

offtherailz opened this issue May 14, 2024 · 0 comments · Fixed by #10344 or #10452
Assignees
@ElenaGallo @mahmoudadel54
Labels
Accepted bug C277-REGION_DE_MURCIA-2024-SUPPORT
Milestone
2024.01.02

Comments

@offtherailz
Copy link
Member

offtherailz commented May 14, 2024 •
edited by tdipisa
Loading

Description

When switching between projections, the scale selector becomes buggy and is not responding correctly.

How to reproduce

I tested this locally and I verified that the issue you find happens even without the projection, so also switching in EPSG:4326 from Web mercator
Here I recorded the evolution of the state locally that can be used for the investigation .

screencast-bpconcjcammlapcogcnnelfmaeghhagj-2024.05.06-10_43_51.webm

Expected Result
The selector should be consistent with the map and the final print.

Current Result
When switching SRS, the selector do not work.

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information

Review to be assigned to @offtherailz
Connected support issue https://github.com/geosolutions-it/support/issues/3313
@tdipisa tdipisa added this to the 2024.01.01 milestone May 14, 2024
@tdipisa tdipisa assigned mahmoudadel54 and unassigned tdipisa May 14, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue May 20, 2024
@mahmoudadel54
geosolutions-it#10322: Fix scale selector to make it compatible with …
8f23219 
…different projections

Description:
- fix the bug by using the updated scaleZoom value instead of the projected value
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue May 20, 2024
@mahmoudadel54
geosolutions-it#10322: Fix scale selector to make it compatible with …
6cbb710 
…different projections

Description:
- add helpful comment
@mahmoudadel54 mahmoudadel54 mentioned this issue May 20, 2024
Merged
12 tasks
@mahmoudadel54 mahmoudadel54 linked a pull request May 20, 2024 that will close this issue
#10322: Fix scale selector to make it compatible with different projections #10344
Merged
12 tasks
@tdipisa tdipisa modified the milestones: 2024.01.01, 2024.01.02 May 28, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue May 30, 2024
@mahmoudadel54
geosolutions-it#10322: Fix scale selector to make it compatible with …
138ae35 
…different projections

Description:
- fix not compatablity projections issue
- add unit tests
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jun 24, 2024
@mahmoudadel54
geosolutions-it#10322: Fix scale selector to make it compatible with …
4d7c386 
…different projections

Description:
- resolve review comments related to unit tests [replace async/await with then + remove unnecessary async/await]
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jun 27, 2024
@mahmoudadel54
geosolutions-it#10322: Fix scale selector to make it compatible with …
616b9e2 
…different projections

Description:
- fix issues of not consistent map print scales with the current map view
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jun 27, 2024
@mahmoudadel54
geosolutions-it#10322: Fix scale selector to make it compatible with …
3101be4 
…different projections

Description:
- fix FE issue
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jun 28, 2024
@mahmoudadel54
geosolutions-it#10322: Fix scale selector to make it compatible with …
458c53c 
…different projections

Description:
- resolve FE failure due to changes
tdipisa pushed a commit that referenced this issue Jul 1, 2024
@mahmoudadel54 @offtherailz
#10322: Fix scale selector to make it compatible with different proje…
b369af2 
…ctions (#10344)

* #10322: Fix scale selector to make it compatible with different projections
Description:
- fix the bug by using the updated scaleZoom value instead of the projected value

* #10322: Fix scale selector to make it compatible with different projections
Description:
- add helpful comment

* #10322: Fix scale selector to make it compatible with different projections
Description:
- fix not compatablity projections issue
- add unit tests

* #10322: Fix scale selector to make it compatible with different projections
Description:
- resolve review comments related to unit tests [replace async/await with then + remove unnecessary async/await]

* #10322: Fix scale selector to make it compatible with different projections
Description:
- fix issues of not consistent map print scales with the current map view

* #10322: Fix scale selector to make it compatible with different projections
Description:
- fix FE issue

* Fixed preview

* #10322: Fix scale selector to make it compatible with different projections
Description:
- resolve FE failure due to changes

---------

Co-authored-by: Lorenzo Natali <[email protected]>
@ElenaGallo ElenaGallo self-assigned this Jul 2, 2024
@ElenaGallo ElenaGallo added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jul 2, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jul 3, 2024
@mahmoudadel54 @offtherailz
geosolutions-it#10322: Fix scale selector to make it compatible with …
5ca5d85 
…different projections (geosolutions-it#10344)

* geosolutions-it#10322: Fix scale selector to make it compatible with different projections
Description:
- fix the bug by using the updated scaleZoom value instead of the projected value

* geosolutions-it#10322: Fix scale selector to make it compatible with different projections
Description:
- add helpful comment

* geosolutions-it#10322: Fix scale selector to make it compatible with different projections
Description:
- fix not compatablity projections issue
- add unit tests

* geosolutions-it#10322: Fix scale selector to make it compatible with different projections
Description:
- resolve review comments related to unit tests [replace async/await with then + remove unnecessary async/await]

* geosolutions-it#10322: Fix scale selector to make it compatible with different projections
Description:
- fix issues of not consistent map print scales with the current map view

* geosolutions-it#10322: Fix scale selector to make it compatible with different projections
Description:
- fix FE issue

* Fixed preview

* geosolutions-it#10322: Fix scale selector to make it compatible with different projections
Description:
- resolve FE failure due to changes

---------

Co-authored-by: Lorenzo Natali <[email protected]>
@mahmoudadel54 mahmoudadel54 mentioned this issue Jul 3, 2024
Merged
@mahmoudadel54 mahmoudadel54 linked a pull request Jul 3, 2024 that will close this issue
[Backport 2024.01.xx] - #10322: Fix scale selector to make it compatible with different projections (#10344) #10452
Merged
tdipisa pushed a commit that referenced this issue Jul 3, 2024
@mahmoudadel54 @offtherailz
[Backport 2024.01.xx] - #10322: Fix scale selector to make it compati…
8529d7d 
…ble with different projections (#10344) (#10452)

* #10418: Share tool - the 'Add place mark and zoom to sharing link' option is not applied correctly (#10419)

* #10322: Fix scale selector to make it compatible with different projections (#10344)

* #10322: Fix scale selector to make it compatible with different projections
Description:
- fix the bug by using the updated scaleZoom value instead of the projected value

* #10322: Fix scale selector to make it compatible with different projections
Description:
- add helpful comment

* #10322: Fix scale selector to make it compatible with different projections
Description:
- fix not compatablity projections issue
- add unit tests

* #10322: Fix scale selector to make it compatible with different projections
Description:
- resolve review comments related to unit tests [replace async/await with then + remove unnecessary async/await]

* #10322: Fix scale selector to make it compatible with different projections
Description:
- fix issues of not consistent map print scales with the current map view

* #10322: Fix scale selector to make it compatible with different projections
Description:
- fix FE issue

* Fixed preview

* #10322: Fix scale selector to make it compatible with different projections
Description:
- resolve FE failure due to changes

---------

Co-authored-by: Lorenzo Natali <[email protected]>

---------

Co-authored-by: Lorenzo Natali <[email protected]>
@ElenaGallo ElenaGallo added Accepted and removed BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaGallo ElenaGallo

@mahmoudadel54 mahmoudadel54

Labels
Accepted bug C277-REGION_DE_MURCIA-2024-SUPPORT
Projects
None yet
Milestone
2024.01.02
4 participants
@offtherailz @tdipisa @ElenaGallo @mahmoudadel54