Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set OL as default mapType also for 2D map in mobile #10167

Closed
1 task done
tdipisa opened this issue Apr 5, 2024 · 0 comments · Fixed by #10267 or #10337
Closed
1 task done

Set OL as default mapType also for 2D map in mobile #10167

tdipisa opened this issue Apr 5, 2024 · 0 comments · Fixed by #10267 or #10337
Assignees
@ElenaGallo @mahmoudadel54
Labels
Accepted Configuration enhancement Internal
Milestone
2024.01.01

Comments

@tdipisa
Copy link
Member

tdipisa commented Apr 5, 2024 •
edited
Loading

Description

Since #8990 and #9012 a new mapType config has been introduced. OL should be configured as default mapType also for mobile maps in 2D.

The correct configuration is the one linked here.

How to reproduce

  • Open a map with mobile

Expected Result

OL should be used as default for 2D maps in mobile.

Current Result

lefalet.webm
  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information
@tdipisa tdipisa added the bug label Apr 5, 2024
@tdipisa tdipisa added this to the 2024.01.00 milestone Apr 5, 2024
@tdipisa tdipisa assigned tdipisa and unassigned allyoucanmap Apr 5, 2024
@tdipisa tdipisa changed the title Restore OL as default mapType for 2D map in mobile Set OL as default mapType also for 2D map in mobile Apr 5, 2024
@tdipisa tdipisa modified the milestones: 2024.01.00, 2024.01.01 Apr 5, 2024
@tdipisa tdipisa added enhancement BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch and removed bug labels Apr 5, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Apr 30, 2024
@mahmoudadel54
geosolutions-it#10167: Set OL as default mapType also for 2D map in m…
c2a7f65 
…obile

Description:
- set ol as a default for 2d map for mobile
- edit the scale bar style to be at the left-bottom
@mahmoudadel54 mahmoudadel54 mentioned this issue Apr 30, 2024
Merged
12 tasks
@tdipisa tdipisa linked a pull request May 2, 2024 that will close this issue
#10167: Set OL as default mapType also for 2D map in mobile #10267
Merged
12 tasks
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue May 15, 2024
@mahmoudadel54
geosolutions-it#10167: Set OL as default mapType also for 2D map in m…
5020967 
…obile

Description:
- remove all related code using ol-mobile
- add the required style for ol-scale-line
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue May 15, 2024
@mahmoudadel54
geosolutions-it#10167: Set OL as default mapType also for 2D map in m…
43ded60 
…obile

Description:
- remove unused props from openlayers/scalebar.jsx
- edit in ol.less style
allyoucanmap pushed a commit that referenced this issue May 16, 2024
@mahmoudadel54
#10167: Set OL as default mapType also for 2D map in mobile (#10267)
94637b8
@ElenaGallo ElenaGallo self-assigned this May 16, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue May 17, 2024
@mahmoudadel54
geosolutions-it#10167: Set OL as default mapType also for 2D map in m…
783b45a 
…obile (geosolutions-it#10267)
@mahmoudadel54 mahmoudadel54 mentioned this issue May 17, 2024
Merged
@mahmoudadel54 mahmoudadel54 linked a pull request May 17, 2024 that will close this issue
[Backport 2024.01.xx]: #10167: Set OL as default mapType also for 2D map in mobile (#10267) #10337
Merged
allyoucanmap pushed a commit that referenced this issue May 17, 2024
@mahmoudadel54
#10167: Set OL as default mapType also for 2D map in mobile (#10267) (#…
6ecab1f 
…10337)
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaGallo ElenaGallo

@mahmoudadel54 mahmoudadel54

Labels
Accepted Configuration enhancement Internal
Projects
None yet
Milestone
2024.01.01
5 participants
@offtherailz @tdipisa @allyoucanmap @ElenaGallo @mahmoudadel54