-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify GeosCore module initializations to accept the same arguments #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(am_I_Root, Input_Opt, State_Chm, State_Diag, RC) This is done in preparation for moving USE-associated arrays in these modules to State_Chm, permitting multi-domain GC-WRF coupling. Signed-off-by: Haipeng Lin <[email protected]>
These changes passed diff tests and unit tests |
yantosca
added a commit
that referenced
this pull request
Jan 28, 2019
Rename ND42 slot #9 to "POA_C" and ND42 slot #10 to "OPOA_C" to avoid name confusion with ND42 slots #4 and #5. This will write the tracerinfo.dat file with unique ND42 tracer names. Signed-off-by: Bob Yantosca <[email protected]>
msulprizio
pushed a commit
that referenced
this pull request
Aug 1, 2019
yantosca
added a commit
that referenced
this pull request
Jan 25, 2023
test/GCClassic/README.md test/GCHP/README.md - Added point #2 to instruct the user to run the Git commmand "git submodule update --init --recursive" to make sure that all submodules are checked otut to the proper place. - Updated points #3 & #4 to include the instruction to check out the proper branch if the GEOS-Chem/HEMCO submodules do not point to the proper commit. This is because very often we test branches that are updated in GEOS-Chem/HEMCO but not in the superprojects. Signed-off-by: Bob Yantosca <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit unifies all modules in
GeosCore
to accept the same set of arguments -(am_I_Root, Input_Opt, State_Chm, State_Diag, RC)
This is done in preparation for moving USE-associated arrays that are dependent on grid sizing (i.e.
(IIPAR, JJPAR, LLPAR)
) in these modulesto
State_Chm
, permitting multi-domain GC-WRF coupling and, in a broader sense, running simultaneous instances of GEOS-Chem modules in the same CPU.Important Note: GCHP Code Update Necessary
This commit changes the entry point for
Init_TOMS
which is being called in GCHP bygigc_chunk_mod.F90
, breaking compilation for GCHP.Solution: That entry point should be removed - please refer to the following code context taken from
gigc_chunk_mod
, around lines 305:Within
GC_Init_Extra
(fromGC_Environment_Mod
), the following already exists:Which runs independent of
Input_Opt%LCHEM
selection. Therefore I believe that in the GCHP source, theInit_TOMS
code is redundant and should be removed. It does not throw a duplicate allocation error, because there areALLOCATED
sanity checks withinInit_TOMS
code.Signed-off-by: Haipeng Lin [email protected]