Add OH perturbation option for CH4 simulations via HEMCO #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new option `OH_perturbation_factor` has been added to geoschem_config.rc for CH4, tag CH4, and carbon simulations. This option is added to facilitate optimizing for OH in the Integrated Methane Inversion (IMI). The scaling of OH is currently done in global_ch4_mod.F90, but it would be more straightforward to do this in HEMCO_Config.rc. Also in this commit, other CH4 options have been slightly renamed for clarity: - Input_Opt%AnalyticalInv -> Input_Opt%DoAnalyticalInv - Input_Opt%PerturbEmis -> Input_Opt%EmisPerturbFactor - Input_Opt%PerturbCH4BoundaryConditions -> DoPerturbCH4BoundaryConditions The options for using emissions and OH scale factors from a previous inversion have been moved to the end of the CH4 options list so that the options for the Jacobian runs within the IMI framework are grouped together. Signed-off-by: Melissa Sulprizio <[email protected]>
Previously, we specified OH perturbation scale factor in geoschem_config.rc and applied the perturbation in global_ch4_mod.F90. This is now more easily done in HEMCO_Config.rc. The default is to use 1.0 (i.e. no scaling) for `OH_pert_factor`, which is applied to the GLOBAL_OH field read into HEMCO. Signed-off-by: Melissa Sulprizio <[email protected]>
yantosca
requested changes
Oct 4, 2023
There was a problem hiding this comment.
@msulprizio: Looks good but I had a couple of questions re: scale factor numbering (3 vs 2). Was wondering if these were typos.
| @@ -1296,7 +1296,7 @@ Mask fractions: false | |||
| #------------------------------------------------------------------------------ | |||
| # --- OH from GEOS-Chem v5-07 [kg/m3], needed for CH4/IMI --- | |||
| (((GLOBAL_OH_GCv5 | |||
| * GLOBAL_OH $ROOT/OH/v2022-11/v5-07-08/OH_3Dglobal.geos5.47L.4x5.nc OH 1985/1-12/1/0 C xyz kg/m3 * - 1 1 | |||
| * GLOBAL_OH $ROOT/OH/v2022-11/v5-07-08/OH_3Dglobal.geos5.47L.4x5.nc OH 1985/1-12/1/0 C xyz kg/m3 * 3 1 1 | |||
There was a problem hiding this comment.
@msulprizio: Should the "3" be "2" instead?
There was a problem hiding this comment.
Thanks for catching that. It is now fixed in 3af9d3b.
| @@ -718,7 +718,7 @@ ${RUNDIR_CH4_LOSS} | |||
|
|
|||
| # --- Global OH from GEOS-Chem v5-07 [kg/m3] --- | |||
| (((GLOBAL_OH | |||
| * GLOBAL_OH $ROOT/OH/v2014-09/v5-07-08/OH_3Dglobal.geos5.47L.4x5.nc OH 1985/1-12/1/0 C xyz kg/m3 * - 1 1 | |||
| * GLOBAL_OH $ROOT/OH/v2014-09/v5-07-08/OH_3Dglobal.geos5.47L.4x5.nc OH 1985/1-12/1/0 C xyz kg/m3 * 3 1 1 | |||
There was a problem hiding this comment.
@msulprizio: Same Q about "3" vs "2".
There was a problem hiding this comment.
Also fixed in 3af9d3b.
The scale factor for perturbing GLOBAL_OH should be 2, not 3, since this corresponds to the OH_perf_factor scale factor ID. The GCHP HEMCO_Config.rc.carbon file has also been updated here for consistency with the GCClassic version. Signed-off-by: Melissa Sulprizio <[email protected]>
yantosca
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Thanks @msulprizio! Good to merge. I'll start bringing it into 14.2.1.
|
All GEOS-Chem Classic integration tests (except for TOMAS) passed: ==============================================================================
GEOS-Chem Classic: Execution Test Results
GCClassic #04f01ee GEOS-Chem submod update: Merge GEOS-Chem 14.2.0 into dev/14.2.1
GEOS-Chem #339ab09b1 Merge PR #1977 (Add OH perturb. option for CH4 simulations)
HEMCO #57ec185 Merge branch 'main' (HEMCO 3.7.0) into dev/3.7.1
Using 24 OpenMP threads
Number of execution tests: 27
Submitted as SLURM job: 4165024
==============================================================================
Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 25
Execution tests failed: 2
Execution tests not yet completed: 0All GCHP integration tests also passed: ==============================================================================
GCHP: Execution Test Results
GCClassic #dd767dc GEOS-Chem submod update: Merge GEOS-Chem 14.2.0 into dev/14.2.1
GEOS-Chem #339ab09b1 Merge PR #1977 (Add OH perturb. option for CH4 simulations)
HEMCO #57ec185 Merge branch 'main' (HEMCO 3.7.0) into dev/3.7.1
Number of execution tests: 5
Submitted as SLURM job: 4165038
==============================================================================
Execution tests:
------------------------------------------------------------------------------
gchp_merra2_fullchem................................Execute Simulation....PASS
gchp_merra2_fullchem_benchmark......................Execute Simulation....PASS
gchp_merra2_fullchem_RRTMG..........................Execute Simulation....PASS
gchp_merra2_tagO3...................................Execute Simulation....PASS
gchp_merra2_TransportTracers........................Execute Simulation....PASS
Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 5
Execution tests failed: 0
Execution tests not yet completed: 0
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
2 tasks
msulprizio
added
the
topic: Carbon Gases Simulations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Melissa Sulprizio
Institution: Harvard / GCST
Describe the update
This update defines a new scale factor
OH_pert_factorin HEMCO_Config.rc for CH4, tagCH4, and carbon simulations. The scale factor is applied to the GLOBAL_OH field, also specified in HEMCO_Config.rc. The default value for the scale factor is 1.0 (i.e. apply no perturbation).This update was made to facilitate optimization of OH for global inversions within the IMI framework.
Related Github Issue(s)