Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Use DO I=1,N for interpolated data in routine Check_AvailYMDhm #85

Merged
merged 2 commits into from
Apr 29, 2021

Conversation

yantosca
Copy link
Contributor

This PR addresses a bug encountered when reading interpolated data such as Yuan_XLAI. For details, see commit d224b1e.

A previous fix in HEMCO 3.0.0-rc.3 changed DO I = 1, N (which would
have caused an out-of-bounds error) to DO I = 1, N-1 in routine
Check_AvailYMDhm (in hcoio_util_mod.F90).  However, for
interpolated data (such as Yuan_XLAI), this causes the check for
the closest time point to fail.

We have put in a check that sets the upper loop limit to N for
interpolated data (if HCO_CFLAG_INTER = True), and to N-1 otherwise.

Signed-off-by: Bob Yantosca <[email protected]>
@yantosca yantosca changed the base branch from main to dev April 29, 2021 16:17
@yantosca yantosca merged commit 00148d0 into dev Apr 29, 2021
@yantosca yantosca deleted the bugfix/bmy/interp branch April 29, 2021 20:32
@yantosca yantosca added category: Bug Fix Fixes a bug that was previously reported and removed category: Bug Something isn't working labels Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Fix Fixes a bug that was previously reported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants