Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update IsModelLevel check for CESM and WRF-GC #244

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Update IsModelLevel check for CESM and WRF-GC #244

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8f5d8b
Update IsModelLevel check for CESM and WRF-GC due to regression in HE…
jimmielin Oct 23, 2023
92d2632
Fix comment formatting
jimmielin Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions src/Core/hcoio_read_std_mod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,12 +695,39 @@ SUBROUTINE HCOIO_Read( HcoState, Lct, RC )
! going to 72 levels. Otherwise, use MESSy (nbalasus, 8/24/2023).
IF ( Lct%Dct%Dta%Levels == 0 ) THEN

#if defined( MODEL_CESM ) || defined( MODEL_WRF )

! In WRF/CESM, IsModelLevel has a different meaning of "GEOS-Chem levels"
! because the models in WRF and CESM are user-defined and thus fixed input
! files would never be on the model level. In this case, a check is added
! in order to match the file with known GEOS-Chem levels, and if so, the
! data will be handled later in this file accordingly to be vertically
! regridded to the runtime model levels using MESSy.
! This fixes a regression from the vertical regridding fixes in 3.7.1.
!
! The meaning of "is model levels" in WRF and CESM are different.
! Model levels can be changed and thus data is never on the model level.
! In this case, IsModelLevel means that the data is on standard
! GEOS-Chem levels, and if so, the data will be handled accordingly
! using a hard-coded set of GEOS-Chem levels to be interpolated using MESSy.
! (hplin, 10/15/23)
IF ( TRIM(LevUnit) == "level" .or. TRIM(LevUnit) == "GEOS-Chem level" ) THEN
! the below check will be obsolete and is unmaintainable, but would be consistent with ModelLev_Check.
! it is more robust to check for the explicit intention of LevUnit
! nlev == 47 .or. nlev == 48 .or. nlev == 36 .or. nlev == 72 .or. nlev == 73 ) THEN
IsModelLevel = .true.
ENDIF

#else

CALL ModelLev_Check( HcoState, nlev, IsModelLevel, RC )
IF ( RC /= HCO_SUCCESS ) THEN
CALL HCO_ERROR( 'ERROR 3', RC, THISLOC=LOC )
RETURN
ENDIF

#endif

! Set level indeces to be read
lev1 = 1
lev2 = nlev
Expand Down