Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a utility script that can be used to change HEMCO version numbers before release #242

Merged
merged 6 commits into from
Nov 27, 2023

Conversation

yantosca
Copy link
Contributor

@yantosca yantosca commented Oct 10, 2023

Name and Institution (Required)

Name: Bob Yantosca
Institution: Harvard + GCST

Confirm you have reviewed the following documentation

Describe the update

This PR adds a utility script (.release/changeVersionNumbers.sh) to update version numbers before a HEMCO release in the proper locations:

  • CMakeLists.txt
  • docs/source/conf.py
  • src/Core/src/hco_error_mod.F90

Example:

$ ./.release/changeVersionNumbers.sh 4.0.0
HEMCO version updated to 4.0.0 in CMakeLists.txt
HEMCO version updated to 4.0.0 in docs/source/conf.py
HEMCO version updated to 4.0.0 in src/Core/hco_error_mod.F90

Expected changes

This is a no-diff-to-benchmark update.

Reference(s)

N/A

Related Github Issue(s)

N/A

.release/changeVersionNumbers.sh
- Script that changes the HEMCO version numbers in the relevant
  locations.  Use before releasing a new version.

Signed-off-by: Bob Yantosca <[email protected]>
$files[@] --> ${files[@]}

Signed-off-by: Bob Yantosca <[email protected]>
This merge brings the feature/change-version-numbers branch
up-to-date with HEMCO 3.7.1

Signed-off-by: Bob Yantosca <[email protected]>
@yantosca yantosca self-assigned this Oct 10, 2023
@yantosca yantosca requested review from msulprizio and removed request for msulprizio October 10, 2023 20:10
@yantosca yantosca added category: Feature Request New feature or request no-diff-to-benchmark This update will have no impact on benchmark simulations labels Nov 21, 2023
.release/changeVersionNumbers.sh
- Add "Harmonized Emissions Component (HEMCO)" to doc header
- Place code in the main() routine
- Call main and return the status to the shell
- Replace tabs with spaces

Signed-off-by: Bob Yantosca <[email protected]>
.release/changeVersionNumbers.sh
- Add more descriptive function headers
- Bug fix: "main()" -> "main" near end of script
- Now error check # of arguments outside of main()

Signed-off-by: Bob Yantosca <[email protected]>
@yantosca yantosca added this to the 3.7.2 milestone Nov 21, 2023
@yantosca yantosca changed the base branch from main to dev/no-diff-to-benchmark November 21, 2023 19:09
@yantosca yantosca marked this pull request as ready for review November 21, 2023 19:10
@yantosca yantosca changed the title [WIP] Include a utility script that can be used to change HEMCO version numbers before release Include a utility script that can be used to change HEMCO version numbers before release Nov 21, 2023
Copy link
Contributor

@msulprizio msulprizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! We should add a similar script to the geos-chem, GCClassic, and GCHP repos.

It would be nice to eventually extend this to update the CHANGELOG.md to automatically add the release date and remove "unreleased" from the version line.

Copy link
Contributor Author

I'll work on this for the other repos. Thanks @msulprizio and Happy Thanksgiving!

.release/changeVersionNumbers.sh
- Modified to also update the version number and the current
  date in the CHANGELOG.md file.  Looks for "Unreleased" in brackets
  and ignores any text that follows as the string to replace.

Signed-off-by: Bob Yantosca <[email protected]>
@yantosca
Copy link
Contributor Author

@msulprizio: I've added code to also update the version number and current date in commit 52731cf.

@msulprizio
Copy link
Contributor

@msulprizio: I've added code to also update the version number and current date in commit 52731cf.

Looks great. Thanks!

@yantosca yantosca merged commit d56ede5 into dev/no-diff-to-benchmark Nov 27, 2023
@yantosca yantosca deleted the feature/change-version-numbers branch November 27, 2023 15:51
yantosca added a commit that referenced this pull request Dec 1, 2023
This is the official release of HEMCO 3.7.2.  Updates include:

- Add utility scripts to change version numbers before release (PR #242)
- Rename HEMCO Config.rc.sample to HEMCO_Config.rc for standalone (PR #245)
- Increase string length for netCDF variable name (PR #248)
- Turn off emission extensions when EMISSIONS logical is false (PR #250)

Signed-off-by: Bob Yantosca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Feature Request New feature or request no-diff-to-benchmark This update will have no impact on benchmark simulations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants